You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/02/11 03:40:13 UTC

[GitHub] xuchaoguo1983 opened a new issue #1857: pagination is not working well after 3.1.0

xuchaoguo1983 opened a new issue #1857: pagination is not working well after 3.1.0
URL: https://github.com/apache/incubator-shardingsphere/issues/1857
 
 
   I have a table with no sharding configuration, if I try to ask a page request with certain offset (not zero), it will always return the first page.
   
   I took a look at class DQLMergeEngine, and found that some weird code below.
   `@Override
       public MergedResult merge() throws SQLException {
           if (1 == queryResults.size()) {
               return new IteratorStreamMergedResult(queryResults);
           }
           selectStatement.setIndexForItems(columnLabelIndexMap);
           return decorate(build());
       }`
       
   it will always return IteratorStreamMergedResult instance even it's a select request with limit.
   
   It's working at 3.0.0 with different logic, please take a look.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services