You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/09/21 21:18:28 UTC
Review Request 68803: Fixed flaky test
`RemoveExecutorUponFailedLaunch`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68803/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
The scheduler `statusUpdate` call expectation is not
necessary and may not get hit in some cases, leading
to flakiness. Replaced `WillOnce` with `AtMost(1)`.
Diffs
-----
src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
Diff: https://reviews.apache.org/r/68803/diff/1/
Testing
-------
make check
run `RemoveExecutorUponFailedLaunch` continuously without failure
Thanks,
Meng Zhu
Re: Review Request 68803: Fixed flaky test
`RemoveExecutorUponFailedLaunch`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68803/#review208905
-----------------------------------------------------------
PASS: Mesos patch 68803 was successfully built and tested.
Reviews applied: `['68803']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2373/mesos-review-68803
- Mesos Reviewbot Windows
On Sept. 21, 2018, 9:18 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68803/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 9:18 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The scheduler `statusUpdate` call expectation is not
> necessary and may not get hit in some cases, leading
> to flakiness. Replaced `WillOnce` with `AtMost(1)`.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
>
>
> Diff: https://reviews.apache.org/r/68803/diff/1/
>
>
> Testing
> -------
>
> make check
> run `RemoveExecutorUponFailedLaunch` continuously without failure
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68803: Fixed flaky test
`RemoveExecutorUponFailedLaunch`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68803/#review208890
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Sept. 21, 2018, 9:18 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68803/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 9:18 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The scheduler `statusUpdate` call expectation is not
> necessary and may not get hit in some cases, leading
> to flakiness. Replaced `WillOnce` with `AtMost(1)`.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1
>
>
> Diff: https://reviews.apache.org/r/68803/diff/1/
>
>
> Testing
> -------
>
> make check
> run `RemoveExecutorUponFailedLaunch` continuously without failure
>
>
> Thanks,
>
> Meng Zhu
>
>