You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by BJ Freeman <bj...@free-man.net> on 2011/02/11 03:26:29 UTC
Product Jump in Catalog
the behavior was if you put in a productID that did not exist, and did a
jump to product, instead of a message No existing Products found, the
/catalog/control/EditProduct enter the ID.
then all you had to do was do an update to create the new product.
is there a reason this functionality was removed.
=========================
BJ Freeman
Strategic Power Office with Supplier Automation <http://www.businessesnetwork.com/automation/viewforum.php?f=52>
Specialtymarket.com <http://www.specialtymarket.com/>
Systems Integrator-- Glad to Assist
Chat Y! messenger: bjfr33man
Re: Product Jump in Catalog
Posted by BJ Freeman <bj...@free-man.net>.
thanks will check it out soon
Jacques Le Roux sent the following on 2/11/2011 1:34 AM:
> I have created https://issues.apache.org/jira/browse/OFBIZ-4177 and
> attached a patch there
>
> It seems to works well. Could you please make more tests?
>
> It seems to me that removing
> <not><if-empty field="productId"/></not>
> when there is also
> <not><if-empty field="product"/></not>
> in the <and condition
> is not an issue but I wonder why it's there
>
> Also I removed a
> <if-empty field="productId"/>
> which seems useless, but I have a doubt...
>
> If it's ok, I will commit
>
> Thanks
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
>> I remember changing this during 2010 (can't find the revision)
>>
>> It was leading to a bug for any other screen (but
>> EditProductQuickAdmin and I just found that) than product creation,
>> since there
>> was no related productId (try prices screen in stable demo for
>> instance). It could be arranged for the product creation screen.
>> But as it's done for all product screens in CommonProductDecorator
>> it's not as easy. Feel free to provide a patch, the idea is to
>> handle it in each screen instead of at the decorator level. This is
>> done in EditProductQuickAdmin.ftl and should be done for other
>> screen at the screen level
>>
>> Thanks
>>
>> Jacques
>>
>> From: "BJ Freeman" <bj...@free-man.net>
>>> the behavior was if you put in a productID that did not exist, and
>>> did a jump to product, instead of a message No existing
>>> Products found, the /catalog/control/EditProduct enter the ID.
>>> then all you had to do was do an update to create the new product.
>>>
>>> is there a reason this functionality was removed.
>>>
>>>
>>> =========================
>>> BJ Freeman
>>> Strategic Power Office with Supplier Automation
>>> <http://www.businessesnetwork.com/automation/viewforum.php?f=52>
>>> Specialtymarket.com <http://www.specialtymarket.com/>
>>> Systems Integrator-- Glad to Assist
>>>
>>> Chat Y! messenger: bjfr33man
>>>
>>
>>
>
>
>
Re: Product Jump in Catalog
Posted by Jacques Le Roux <ja...@les7arts.com>.
I have created https://issues.apache.org/jira/browse/OFBIZ-4177 and attached a patch there
It seems to works well. Could you please make more tests?
It seems to me that removing
<not><if-empty field="productId"/></not>
when there is also
<not><if-empty field="product"/></not>
in the <and condition
is not an issue but I wonder why it's there
Also I removed a
<if-empty field="productId"/>
which seems useless, but I have a doubt...
If it's ok, I will commit
Thanks
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
>I remember changing this during 2010 (can't find the revision)
>
> It was leading to a bug for any other screen (but EditProductQuickAdmin and I just found that) than product creation, since there
> was no related productId (try prices screen in stable demo for instance). It could be arranged for the product creation screen.
> But as it's done for all product screens in CommonProductDecorator it's not as easy. Feel free to provide a patch, the idea is to
> handle it in each screen instead of at the decorator level. This is done in EditProductQuickAdmin.ftl and should be done for other
> screen at the screen level
>
> Thanks
>
> Jacques
>
> From: "BJ Freeman" <bj...@free-man.net>
>> the behavior was if you put in a productID that did not exist, and did a jump to product, instead of a message No existing
>> Products found, the /catalog/control/EditProduct enter the ID.
>> then all you had to do was do an update to create the new product.
>>
>> is there a reason this functionality was removed.
>>
>>
>> =========================
>> BJ Freeman
>> Strategic Power Office with Supplier Automation <http://www.businessesnetwork.com/automation/viewforum.php?f=52>
>> Specialtymarket.com <http://www.specialtymarket.com/>
>> Systems Integrator-- Glad to Assist
>>
>> Chat Y! messenger: bjfr33man
>>
>
>
Re: Product Jump in Catalog
Posted by Jacques Le Roux <ja...@les7arts.com>.
I remember changing this during 2010 (can't find the revision)
It was leading to a bug for any other screen (but EditProductQuickAdmin and I just found that) than product creation, since there
was no related productId (try prices screen in stable demo for instance). It could be arranged for the product creation screen. But
as it's done for all product screens in CommonProductDecorator it's not as easy. Feel free to provide a patch, the idea is to handle
it in each screen instead of at the decorator level. This is done in EditProductQuickAdmin.ftl and should be done for other screen
at the screen level
Thanks
Jacques
From: "BJ Freeman" <bj...@free-man.net>
> the behavior was if you put in a productID that did not exist, and did a jump to product, instead of a message No existing
> Products found, the /catalog/control/EditProduct enter the ID.
> then all you had to do was do an update to create the new product.
>
> is there a reason this functionality was removed.
>
>
> =========================
> BJ Freeman
> Strategic Power Office with Supplier Automation <http://www.businessesnetwork.com/automation/viewforum.php?f=52>
> Specialtymarket.com <http://www.specialtymarket.com/>
> Systems Integrator-- Glad to Assist
>
> Chat Y! messenger: bjfr33man
>