svn commit: r745211 - /incubator/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java

[li...@apache.org]

Author: lindner
Date: Tue Feb 17 19:37:19 2009
New Revision: 745211

URL: http://svn.apache.org/viewvc?rev=745211&view=rev
Log:
SHINDIG-914 | Log exceptions that get swallowed in Api calls

Modified:
    incubator/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java

Modified: incubator/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java?rev=745211&r1=745210&r2=745211&view=diff
==============================================================================
--- incubator/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java (original)
+++ incubator/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java Tue Feb 17 19:37:19 2009
@@ -30,6 +30,8 @@
 import java.util.Collections;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
@@ -38,6 +40,9 @@
  * Common base class for API servlets.
  */
 public abstract class ApiServlet extends InjectedServlet {
+  
+  private static final Logger logger = Logger.getLogger(ApiServlet.class.getName());
+  
   protected static final String DEFAULT_ENCODING = "UTF-8";
 
   protected HandlerRegistry dispatcher;
@@ -94,9 +99,11 @@
   protected ResponseItem responseItemFromException(Throwable t) {
     if (t instanceof ProtocolException) {
       ProtocolException spe = (ProtocolException) t;
+      logger.log(Level.INFO, "Returning a response error as result of a protocol exception", spe);
       return new ResponseItem(spe.getError(), spe.getMessage());
     }
-
+    
+    logger.log(Level.WARNING, "Returning a response error as result of an exception", t);
     return new ResponseItem(ResponseError.INTERNAL_ERROR, t.getMessage());
   }