You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/04/10 12:54:07 UTC
[GitHub] [incubator-netbeans] arusinha commented on a change in pull request
#1144: [NETBEANS-2284]:NB build with jdk11
arusinha commented on a change in pull request #1144: [NETBEANS-2284]:NB build with jdk11
URL: https://github.com/apache/incubator-netbeans/pull/1144#discussion_r273942032
##########
File path: java/maven.indexer/src/org/netbeans/modules/maven/indexer/OnStop.java
##########
@@ -41,7 +41,8 @@ public void run() {
}
if (t.isAlive()) {
LOG.warning("...hard stop required.");
- t.stop(new Cancellation());
+ // t.stop(new Cancellation());
Review comment:
for t.stop(new Cancellation()) it is okay to remove it as on call of this method it will throw UnsupportedOperationException in jdk-8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists