You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/03/01 04:06:39 UTC

[GitHub] [thrift] finncolman opened a new pull request #2537: THRIFT-5532: Fix headers bug in Thrift/HttpClient.pm

finncolman opened a new pull request #2537:
URL: https://github.com/apache/thrift/pull/2537


   <!-- Explain the changes in the pull request below: -->
   This is fixing a bug in the headers being passed into HTTP::Request. Previously these were being set as a hash reference which is incorrect as it should be either an HTTP::Headers object or an array reference. The details are in the Jira issue.
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2537: THRIFT-5532: Fix headers bug in Thrift/HttpClient.pm

Posted by GitBox <gi...@apache.org>.

Jens-G merged pull request #2537:
URL: https://github.com/apache/thrift/pull/2537


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] finncolman commented on pull request #2537: THRIFT-5532: Fix headers bug in Thrift/HttpClient.pm

Posted by GitBox <gi...@apache.org>.

finncolman commented on pull request #2537:
URL: https://github.com/apache/thrift/pull/2537#issuecomment-1055799740


   The Travis CI build failure doesn't seem to have anything to do with my PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org