You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2018/03/29 19:17:00 UTC
[jira] [Resolved] (VFS-657) FileSelector implementations like
FileDepthSelector should throw Exception
[ https://issues.apache.org/jira/browse/VFS-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Gregory resolved VFS-657.
------------------------------
Resolution: Fixed
Assignee: Gary Gregory
Fix Version/s: 2.2.1
Fixed in svn trunk. Please verify and close this ticket.
{noformat}
commit -m "[VFS-657] FileSelector implementations like FileDepthSelector should throw Exception." -N (7 paths specified)
Sending C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/AllFileSelector.java
Sending C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileDepthSelector.java
Sending C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileExtensionSelector.java
Sending C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileFilterSelector.java
Sending C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/FileTypeSelector.java
Sending C:/vcs/svn/apache/commons/trunks-proper/vfs/commons-vfs2/src/main/java/org/apache/commons/vfs2/PatternFileSelector.java
Sending C:/vcs/svn/apache/commons/trunks-proper/vfs/src/changes/changes.xml
Transmitting file data ...
Unknown action received: commit finalizing
Committed revision 1828015.{noformat}
> FileSelector implementations like FileDepthSelector should throw Exception
> --------------------------------------------------------------------------
>
> Key: VFS-657
> URL: https://issues.apache.org/jira/browse/VFS-657
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Elias Putz
> Assignee: Gary Gregory
> Priority: Major
> Fix For: 2.2.1
>
>
> {{org.apache.commons.vfs2.FileDepthSelector}} should throw an {{Exception}} as stated in the interface {{org.apache.commons.vfs2.FileSelector}}, otherwise if you try to extend it the child class cannot throw an exception.
> I tried to create a class combining the functionality of the {{FileDepthSelector}} and {{FileTypeSelector}} but couldn't because checking the file type throws an exception.
> Another issue: Why is the depth of {{FileFilterSelector}} hard coded?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)