Re: [PR] [SPARK-46677][SQL][CONNECT] Fix `dataframe["*"]` resolution [spark]

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #44689:
URL: https://github.com/apache/spark/pull/44689#discussion_r1448649195


##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -76,15 +76,6 @@
     from pyspark.sql.connect.udtf import UserDefinedTableFunction
 
 
-def _to_col_with_plan_id(col: str, plan_id: Optional[int]) -> Column:

Review Comment:
   delete this helper function due to the behavior difference between `Dataset#col` and `functions#col`
   
   https://github.com/apache/spark/blob/d2f572428be5346dfa412f6588e72686429ddc71/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L1452-L1461
   
   https://github.com/apache/spark/blob/0a791993be7b6f4b843887403460ef9aebe3daf9/sql/core/src/main/scala/org/apache/spark/sql/Column.scala#L154-L162
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org