You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/01 20:16:58 UTC

[jira] [Commented] (BEAM-875) Inconsistency between time types between the inprocess and dataflow runner for BQ

    [ https://issues.apache.org/jira/browse/BEAM-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626545#comment-15626545 ] 

ASF GitHub Bot commented on BEAM-875:
-------------------------------------

GitHub user sb2nov opened a pull request:

    https://github.com/apache/incubator-beam/pull/1250

    [BEAM-875] Make the BQ input for dataflow runner and local runner is identical

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Time related datatypes were not all supported for the local runner as well as timestamps were being serialized different so changing the local runner to match the big query export environment now. 
    
    R: @chamikaramj 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/incubator-beam BEAM-875-datetime-inconsistency

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1250
    
----
commit 28ab78d87393d7b7d57980e2dfdccdc366d213b2
Author: Sourabh Bajaj <so...@google.com>
Date:   2016-11-01T20:06:10Z

    Make the BQ input for dataflow runner and local runner is identical for time related types

----


> Inconsistency between time types between the inprocess and dataflow runner for BQ
> ---------------------------------------------------------------------------------
>
>                 Key: BEAM-875
>                 URL: https://issues.apache.org/jira/browse/BEAM-875
>             Project: Beam
>          Issue Type: Bug
>            Reporter: Sourabh Bajaj
>            Assignee: Sourabh Bajaj
>            Priority: Minor
>
> investigate if we support datatypes TIMESTAMP, DATE, TIME, and DATETIME properly and in a consistent matter across InProcess and Dataflow runners for BQ



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)