You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Diveyam-Mishra (via GitHub)" <gi...@apache.org> on 2026/09/02 11:57:14 UTC
[PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Diveyam-Mishra opened a new pull request, #58476:
URL: https://github.com/apache/spark/pull/58476
### What changes were proposed in this pull request?
This PR resolves an overhead issue with state-store instance metric reporting in `StateStoreWriter`.
Currently, `StateStoreWriter` creates separate `SQLMetric` accumulators for every `(partitionId, metric, storeName)` combination upfront on the physical plan. On executors, every task deserializes and registers all of those accumulators in its `TaskContext`, and includes all of them in the task result payload even though only a single partition was processed.
This PR replaces the upfront $O(\text{numPartitions})$ `SQLMetric` instances with a single `instanceMetricsAccumulator: CollectionAccumulator[(StateStoreInstanceMetric, Long)]` on `StateStoreWriter` (following the pattern of `checkpointInfoAccumulator`). Each task appends only its own active partition's metric updates. The driver then aggregates, sorts, and formats the top-$K$ instance metrics during `getProgress()`.
### Why are the changes needed?
For queries with high partition counts (e.g. 20,000 shuffle partitions), each task was shipping ~3 MiB of unused metric updates, totaling ~60 GiB across tasks. In terminal `ResultStage`s (such as RDD checkpoint materialization or direct file writes), this causes `spark.driver.maxResultSize` errors, severe driver heap pressure, and network congestion.
Fixes https://github.com/apache/spark/issues/58394 and https://issues.apache.org/jira/browse/SPARK-59174.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Added unit test in `StateStoreInstanceMetricSuite`: `"SPARK-59174: StateStoreWriter uses single accumulator for instance metrics"`.
- Ran full `StateStoreInstanceMetricSuite` (all 12 tests passed).
Metric | Before Fix | After Fix
Accumulator objects created | O(N × metrics × stores) — e.g. 20,000–60,000 accumulators | 1 accumulator
Task result payload (per task) | ~3 MiB / task | ~100 bytes / task
### Was this patch authored or co-authored using generative AI tooling?
Yes
Generated-by: Gemini 3.7 Flash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Kimahriman (via GitHub)" <gi...@apache.org>.
Kimahriman commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-5539485776
cc @zecookiez @ericm-db @HeartSaVioR as the original author/reviers of this feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-5845350399
@tdcmeehan @ericm-db Hey Can u review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on code in PR #58476:
URL: https://github.com/apache/spark/pull/58476#discussion_r3937590418
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/statefulOperators.scala:
##########
@@ -230,21 +228,15 @@ trait StateStoreWriter
}
/**
- * Map of all instance metrics (including partition ID and store names) to
- * their SQLMetric counterpart.
- *
- * The instance metric objects hold additional information on how to report these metrics,
- * while the SQLMetric objects store the metric values.
- *
- * This map is similar to the metrics map, but needs to be kept separate to prevent propagating
- * all initialized instance metrics to SparkUI.
+ * Aggregator used for executors to pass instance metrics (per partition/store) back to driver.
*/
- lazy val instanceMetrics: Map[StateStoreInstanceMetric, SQLMetric] =
- stateStoreInstanceMetrics
+ val instanceMetricsAccumulator: CollectionAccumulator[(StateStoreInstanceMetric, Long)] = {
Review Comment:
So I can make `byPartition` protected and create a `StateStoreInstanceMetricAccumulator` subclass that can access the partition map and apply `StateStoreInstanceMetric.combine(...)` instead of inheriting the default last-write-wins behavior of `PartitionKeyedAccumulator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #58476: [SPARK-59174][SS] State-store instance metrics are shipped in every task result
URL: https://github.com/apache/spark/pull/58476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "tdcmeehan (via GitHub)" <gi...@apache.org>.
tdcmeehan commented on code in PR #58476:
URL: https://github.com/apache/spark/pull/58476#discussion_r3959242658
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreInstanceMetricSuite.scala:
##########
@@ -486,6 +489,85 @@ class StateStoreInstanceMetricSuite extends StreamTest with AlsoTestWithRocksDBF
}
}
}
+
+ testWithChangelogCheckpointingEnabled(
+ "SPARK-59174: StateStoreWriter uses single accumulator for instance metrics"
+ ) {
+ withSQLConf(
+ SQLConf.STATE_STORE_PROVIDER_CLASS.key -> classOf[RocksDBStateStoreProvider].getName,
+ SQLConf.SHUFFLE_PARTITIONS.key -> "10",
+ SQLConf.STATE_STORE_MIN_DELTAS_FOR_SNAPSHOT.key -> "1",
+ SQLConf.STREAMING_MAINTENANCE_INTERVAL.key -> "100"
+ ) {
+ withTempDir { checkpointDir =>
+ val inputData = MemoryStream[String]
+ val result = inputData.toDS().dropDuplicates()
+
+ testStream(result, outputMode = OutputMode.Update)(
+ StartStream(checkpointLocation = checkpointDir.getCanonicalPath),
+ AddData(inputData, "a", "b", "c"),
+ ProcessAllAvailable(),
+ Execute { q =>
+ val stateOp = q.lastExecution.executedPlan.collectFirst {
+ case s: StateStoreWriter => s
+ }.get
+ // Verify the accumulator is a PartitionKeyedAccumulator (not a CollectionAccumulator),
+ // has entries for the executed partitions, and does not allocate individual
+ // per-partition SQLMetrics on the plan.
+ val accValue = stateOp.instanceMetricsAccumulator.value
+ assert(!accValue.isEmpty, "accumulator should have entries after processing data")
+ // Each partition's metrics are stored as a Map; flatten all metric keys.
+ val allMetricKeys = accValue.values().asScala.flatMap(_.keys)
+ assert(
+ allMetricKeys.forall(_.name.startsWith(SNAPSHOT_LAG_METRIC_PREFIX)),
+ s"unexpected metric keys: ${allMetricKeys.map(_.name).mkString(", ")}")
+ },
+ StopStream
+ )
+ }
+ }
+ }
+
+ test("SPARK-59174: StateStoreInstanceMetricAccumulator preserves combine semantics") {
+ val metric0 = StateStoreSnapshotLastUploadInstanceMetric(Some(0), "default")
+ val metric0Store2 = StateStoreSnapshotLastUploadInstanceMetric(Some(0), "other")
+ val metric1 = StateStoreSnapshotLastUploadInstanceMetric(Some(1), "default")
+
+ // 1. Add updates to the same partition: commutative combine (max version wins)
+ val acc1 = new StateStoreInstanceMetricAccumulator
+ acc1.add((0, Map(metric0 -> 100L)))
+ acc1.add((0, Map(metric0 -> 105L)))
+ assert(acc1.value.get(0).get(metric0) === Some(105L))
+
+ val acc2 = new StateStoreInstanceMetricAccumulator
+ acc2.add((0, Map(metric0 -> 105L)))
+ acc2.add((0, Map(metric0 -> 100L)))
+ assert(acc2.value.get(0).get(metric0) === Some(105L))
+
+ // Initial value (-1) does not overwrite an existing valid snapshot version
+ acc1.add((0, Map(metric0 -> -1L)))
+ assert(acc1.value.get(0).get(metric0) === Some(105L))
+
+ // 2. Multiple stores within the same partition merge cleanly
+ acc1.add((0, Map(metric0Store2 -> 50L)))
+ assert(acc1.value.get(0).size == 2)
+ assert(acc1.value.get(0).get(metric0) === Some(105L))
+ assert(acc1.value.get(0).get(metric0Store2) === Some(50L))
+
+ // 3. Merge between accumulators: preserves combine semantics across attempts/retries
+ val accA = new StateStoreInstanceMetricAccumulator
+ accA.add((0, Map(metric0 -> 100L)))
+ accA.add((1, Map(metric1 -> 200L)))
+
+ val accB = new StateStoreInstanceMetricAccumulator
+ accB.add((0, Map(metric0 -> 105L)))
+ accB.add((1, Map(metric1 -> 150L)))
+
+ accA.merge(accB)
+ assert(accA.accumulatedNumPartitions == 2)
+ assert(accA.value.get(0).get(metric0) === Some(105L))
+ assert(accA.value.get(1).get(metric1) === Some(200L))
+ }
Review Comment:
This test looks duplicated in `PartitionKeyedAccumulatorSuite`, I would remove this one and just keep the one above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #58476:
URL: https://github.com/apache/spark/pull/58476#discussion_r3984449127
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -681,6 +681,14 @@ trait StateStoreInstanceMetric {
*/
def combine(originalMetric: SQLMetric, value: Long): Long
+ def combine(originalValue: Long, value: Long): Long = {
Review Comment:
Existing StateStoreInstanceMetric implementations are required to implement combine(SQLMetric, Long), but the accumulator now calls this new overload directly and its default is always max. A custom state-store provider whose existing combine method uses min, sum, or another policy will continue to compile but silently get max semantics when duplicate task attempts are merged. Could we preserve the existing combine contract here, or explicitly establish one canonical primitive-value method with compatibility handling? A regression test using a metric whose combine policy differs from max would cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "tdcmeehan (via GitHub)" <gi...@apache.org>.
tdcmeehan commented on code in PR #58476:
URL: https://github.com/apache/spark/pull/58476#discussion_r3926870211
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/operators/stateful/statefulOperators.scala:
##########
@@ -230,21 +228,15 @@ trait StateStoreWriter
}
/**
- * Map of all instance metrics (including partition ID and store names) to
- * their SQLMetric counterpart.
- *
- * The instance metric objects hold additional information on how to report these metrics,
- * while the SQLMetric objects store the metric values.
- *
- * This map is similar to the metrics map, but needs to be kept separate to prevent propagating
- * all initialized instance metrics to SparkUI.
+ * Aggregator used for executors to pass instance metrics (per partition/store) back to driver.
*/
- lazy val instanceMetrics: Map[StateStoreInstanceMetric, SQLMetric] =
- stateStoreInstanceMetrics
+ val instanceMetricsAccumulator: CollectionAccumulator[(StateStoreInstanceMetric, Long)] = {
Review Comment:
Could we use or extend `PartitionKeyedAccumulator` here? Unlike `CollectionAccumulator`, it bounds driver-side state by partition when retries or speculative attempts produce duplicate updates. We would need to preserve `StateStoreInstanceMetric.combine` semantics rather than its default last-write-wins behavior, but that may avoid retaining every successful attempt’s raw metrics on the driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on code in PR #58476:
URL: https://github.com/apache/spark/pull/58476#discussion_r3960147591
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreInstanceMetricSuite.scala:
##########
@@ -486,6 +489,85 @@ class StateStoreInstanceMetricSuite extends StreamTest with AlsoTestWithRocksDBF
}
}
}
+
+ testWithChangelogCheckpointingEnabled(
+ "SPARK-59174: StateStoreWriter uses single accumulator for instance metrics"
+ ) {
+ withSQLConf(
+ SQLConf.STATE_STORE_PROVIDER_CLASS.key -> classOf[RocksDBStateStoreProvider].getName,
+ SQLConf.SHUFFLE_PARTITIONS.key -> "10",
+ SQLConf.STATE_STORE_MIN_DELTAS_FOR_SNAPSHOT.key -> "1",
+ SQLConf.STREAMING_MAINTENANCE_INTERVAL.key -> "100"
+ ) {
+ withTempDir { checkpointDir =>
+ val inputData = MemoryStream[String]
+ val result = inputData.toDS().dropDuplicates()
+
+ testStream(result, outputMode = OutputMode.Update)(
+ StartStream(checkpointLocation = checkpointDir.getCanonicalPath),
+ AddData(inputData, "a", "b", "c"),
+ ProcessAllAvailable(),
+ Execute { q =>
+ val stateOp = q.lastExecution.executedPlan.collectFirst {
+ case s: StateStoreWriter => s
+ }.get
+ // Verify the accumulator is a PartitionKeyedAccumulator (not a CollectionAccumulator),
+ // has entries for the executed partitions, and does not allocate individual
+ // per-partition SQLMetrics on the plan.
+ val accValue = stateOp.instanceMetricsAccumulator.value
+ assert(!accValue.isEmpty, "accumulator should have entries after processing data")
+ // Each partition's metrics are stored as a Map; flatten all metric keys.
+ val allMetricKeys = accValue.values().asScala.flatMap(_.keys)
+ assert(
+ allMetricKeys.forall(_.name.startsWith(SNAPSHOT_LAG_METRIC_PREFIX)),
+ s"unexpected metric keys: ${allMetricKeys.map(_.name).mkString(", ")}")
+ },
+ StopStream
+ )
+ }
+ }
+ }
+
+ test("SPARK-59174: StateStoreInstanceMetricAccumulator preserves combine semantics") {
+ val metric0 = StateStoreSnapshotLastUploadInstanceMetric(Some(0), "default")
+ val metric0Store2 = StateStoreSnapshotLastUploadInstanceMetric(Some(0), "other")
+ val metric1 = StateStoreSnapshotLastUploadInstanceMetric(Some(1), "default")
+
+ // 1. Add updates to the same partition: commutative combine (max version wins)
+ val acc1 = new StateStoreInstanceMetricAccumulator
+ acc1.add((0, Map(metric0 -> 100L)))
+ acc1.add((0, Map(metric0 -> 105L)))
+ assert(acc1.value.get(0).get(metric0) === Some(105L))
+
+ val acc2 = new StateStoreInstanceMetricAccumulator
+ acc2.add((0, Map(metric0 -> 105L)))
+ acc2.add((0, Map(metric0 -> 100L)))
+ assert(acc2.value.get(0).get(metric0) === Some(105L))
+
+ // Initial value (-1) does not overwrite an existing valid snapshot version
+ acc1.add((0, Map(metric0 -> -1L)))
+ assert(acc1.value.get(0).get(metric0) === Some(105L))
+
+ // 2. Multiple stores within the same partition merge cleanly
+ acc1.add((0, Map(metric0Store2 -> 50L)))
+ assert(acc1.value.get(0).size == 2)
+ assert(acc1.value.get(0).get(metric0) === Some(105L))
+ assert(acc1.value.get(0).get(metric0Store2) === Some(50L))
+
+ // 3. Merge between accumulators: preserves combine semantics across attempts/retries
+ val accA = new StateStoreInstanceMetricAccumulator
+ accA.add((0, Map(metric0 -> 100L)))
+ accA.add((1, Map(metric1 -> 200L)))
+
+ val accB = new StateStoreInstanceMetricAccumulator
+ accB.add((0, Map(metric0 -> 105L)))
+ accB.add((1, Map(metric1 -> 150L)))
+
+ accA.merge(accB)
+ assert(accA.accumulatedNumPartitions == 2)
+ assert(accA.value.get(0).get(metric0) === Some(105L))
+ assert(accA.value.get(1).get(metric1) === Some(200L))
+ }
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-6332673896
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/c1cc110301f6f4007c9326cdea623ce79324df13
- merged into branch-4.x https://github.com/apache/spark/commit/e08a697adc845cf020f9bef3ce28450dab2a2dc7
- merged into branch-4.3 https://github.com/apache/spark/commit/65215f17d9c99bae2453603fc9c9cb71ed7bd438
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-6332656523
Thanks! Merging to master/4.x/4.3/4.2/4.1. (I'll stop when there is merge conflict - it doesn't look to be quite mandatory to port back, but still good one to fix.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-5618947284
Whats the tentative time a PR gets merged ? @tdcmeehan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-5674440944
@tdcmeehan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-5526427437
Hey its my first time contributing not knowing how to ask for a review so tagging let me know if there is a different way. (I Read the contributing guide )
@dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-6326359563
Sorry I'll take a quick look. You need a stamp from committers to get merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59174][SS] State-store instance metrics are shipped in every task result [spark]
Posted by "Diveyam-Mishra (via GitHub)" <gi...@apache.org>.
Diveyam-Mishra commented on PR #58476:
URL: https://github.com/apache/spark/pull/58476#issuecomment-6325304688
Hey Saw this was still open
@tdcmeehan @ericm-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org