[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #66: Properly support SBT 1.8.2 and Scala 3

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #66:
URL: https://github.com/apache/incubator-pekko-grpc/pull/66#discussion_r1208114338


##########
project/Common.scala:
##########
@@ -67,20 +89,27 @@ object Common extends AutoPlugin {
       version.value,
       "-sourcepath",
       (ThisBuild / baseDirectory).value.toString,
-      "-skip-packages",
-      "org.apache.pekko.pattern:" + // for some reason Scaladoc creates this
-      "templates",
       "-doc-source-url", {
         val branch = if (isSnapshot.value) "main" else s"v${version.value}"
         s"https://github.com/apache/incubator-pekko-grpc/tree/${branch}€{FILE_PATH_EXT}#L€{FILE_LINE}"
       },
       "-doc-canonical-base-url",
-      "https://pekko.aoache.org/api/pekko-grpc/current/"),
+      "https://pekko.apache.org/api/pekko-grpc/current/") ++ (
+      if (!isScala3.value) {
+        Seq(
+          "-skip-packages",
+          "org.apache.pekko.pattern:" + // for some reason Scaladoc creates this

Review Comment:
   not a big issue - but I think Scala 3 has fixed the issue that requires this skip - when I upgraded another pekko project to support Scala 3, I didn't seem to need this in Scala 3 build and I only set the skip on the Scala 2 build
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org