You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/06 12:47:00 UTC
[GitHub] [skywalking] tzy1316106836 opened a new issue #4186: make a
suggestion about DUBBO plugin
tzy1316106836 opened a new issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] discussion
___
### Question
Dubbo plugin will have the following problems when retrying:
If the current link is triggered by other components that are not monitored, and it does not have EntrySpan, the stackDepth of the link is 0 when the dubbo is called internally. The traceId generated by the call is different. however, if the dubbo call timeout and retry, the traceId is the same, because the sw3 parameter of the last call is reused. In this scenario, The effect of multiple dubbo calls and dubbo retry should be the same. I think the problem needs to be fixed, that is, update the value of sw3 when retrying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4186: make a suggestion
about DUBBO plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186#issuecomment-572379936
fixed by #4187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4186: make a suggestion
about DUBBO plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186#issuecomment-571127870
@tzy1316106836 can you please send a pull request to fix this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] tzy1316106836 closed issue #4186: make a suggestion
about DUBBO plugin
Posted by GitBox <gi...@apache.org>.
tzy1316106836 closed issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] tzy1316106836 commented on issue #4186: make a
suggestion about DUBBO plugin
Posted by GitBox <gi...@apache.org>.
tzy1316106836 commented on issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186#issuecomment-571135530
https://github.com/apache/skywalking/pull/4187/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 closed issue #4186: make a suggestion about
DUBBO plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] tzy1316106836 opened a new issue #4186: make a
suggestion about DUBBO plugin
Posted by GitBox <gi...@apache.org>.
tzy1316106836 opened a new issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] discussion
___
### Question
Dubbo plugin will have the following problems when retrying:
If the current link is triggered by other components that are not monitored, and it does not have EntrySpan, the stackDepth of the link is 0 when the dubbo is called internally. The traceId generated by the call is different. however, if the dubbo call timeout and retry, the traceId is the same, because the sw3 parameter of the last call is reused. In this scenario, The effect of multiple dubbo calls and dubbo retry should be the same. I think the problem needs to be fixed, that is, update the value of sw3 when retrying.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] tzy1316106836 commented on issue #4186: make a
suggestion about DUBBO plugin
Posted by GitBox <gi...@apache.org>.
tzy1316106836 commented on issue #4186: make a suggestion about DUBBO plugin
URL: https://github.com/apache/skywalking/issues/4186#issuecomment-571136438
> @tzy1316106836 can you please send a pull request to fix this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services