You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by dasahcc <gi...@git.apache.org> on 2017/03/08 01:23:00 UTC

[GitHub] helix pull request #74: Three bug fixings and improvements

GitHub user dasahcc opened a pull request:

    https://github.com/apache/helix/pull/74

    Three bug fixings and improvements

    1. Add methods for creating WorkflowContext and JobContext for easy creating mock WorkflowContext nad JobContext.
    2. Test base refactoring and add new synchronize tests
    3. Add back old getInstanceEnabledForPartition function to keep backward compatible

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dasahcc/helix helix-0.6.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit 69e54302cf2b1698a7eb6f5e70f70ec739732021
Author: Junkai Xue <jx...@linkedin.com>
Date:   2017-02-18T00:51:40Z

    Add methods for creating WorkflowContext and JobContext
    
    Add methods for creating WorkflowContext and JobContext

commit 6a956f7cf8bcaa35c8099af4e7bd072eb3322aec
Author: Junkai Xue <jx...@linkedin.com>
Date:   2017-02-18T00:58:50Z

    Test base refactoring and add new synchronize tests
    
    Due to heavy asynchronized tests running in Helix, current tests are running slow. Thus introduce these new synchronized tests to improve the test efficiency.
    1. Split out TaskSynchronizedTestBase.
    2. Add synchronized test for delay jobs.

commit 6e9cc71ed35ba02fa275ec41b547804f99e57b62
Author: Junkai Xue <jx...@linkedin.com>
Date:   2017-03-08T01:20:32Z

    Add back old getInstanceEnabledForPartition function
    
    Add back old getInstanceEnabledForPartition to make backward compatible.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request #74: Three bug fixings and improvements

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix issue #74: Three bug fixings and improvements

Posted by dasahcc <gi...@git.apache.org>.
Github user dasahcc commented on the issue:

    https://github.com/apache/helix/pull/74
  
    Sure. Just updated the commit and pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix issue #74: Three bug fixings and improvements

Posted by lei-xia <gi...@git.apache.org>.
Github user lei-xia commented on the issue:

    https://github.com/apache/helix/pull/74
  
    Could you rebase against the current head?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix issue #74: Three bug fixings and improvements

Posted by dasahcc <gi...@git.apache.org>.
Github user dasahcc commented on the issue:

    https://github.com/apache/helix/pull/74
  
    Rebased now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---