You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/05/26 03:04:05 UTC

DO NOT REPLY [Bug 47263] New: License headers in jsp files break TC 5.5 testsuite

https://issues.apache.org/bugzilla/show_bug.cgi?id=47263

           Summary: License headers in jsp files break TC 5.5 testsuite
           Product: Tomcat 5
           Version: Nightly Build
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Tester
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: knst.kolinko@gmail.com


Ant task that builds a TC 5.5 release includes running a series of tests.

With the current tc5.5.x trunk code those tests display failures,
because of license headers.

Authentication:
   [tester] FAIL [GET /tester/protected/Authentication04 HTTP/1.0] Expected
data 'Authentication04 PASSED', got data '<!--'

ErrorPage:
   [tester] FAIL [GET /tester/ErrorPage05?type=Array HTTP/1.0] Expected data
'ErrorPage06 PASSED - JSP', got data '<!--'
   [tester] FAIL [GET /tester/WrappedErrorPage05?type=Array HTTP/1.0] Expected
data 'ErrorPage06 PASSED - JSP', got data '<!--'
   [tester] FAIL [GET /tester/ErrorPage05?type=Number HTTP/1.0] Expected data
'ErrorPage06 PASSED - HTML', got data '<!--'
   [tester] FAIL [GET /tester/WrappedErrorPage05?type=Number HTTP/1.0] Expected
data 'ErrorPage06 PASSED - HTML', got data '<!--'

and so on...

A trivial fix will be s/<!--/<%--/ s/-->/--%>/ around those licenses.

May be some other pages, besides the test ones, deserve the same fix?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 47263] License headers in jsp files break TC 5.5 testsuite

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47263


Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Konstantin Kolinko <kn...@gmail.com>  2009-06-02 13:14:06 PST ---
Fixed. (r781067, r781140)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org