You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/18 11:49:40 UTC
[GitHub] [incubator-mxnet] marcoabreu commented on issue #17889: Re-enable
coverage on CI for GCC CPU builds
marcoabreu commented on issue #17889: Re-enable coverage on CI for GCC CPU builds
URL: https://github.com/apache/incubator-mxnet/pull/17889#issuecomment-615850612
Actually the coverage is not stable at all. Look at this example report https://codecov.io/gh/apache/incubator-mxnet/pull/17905/changes which is based on #17905. The PR adds one new operator, but 132 files have coverage changes with a reported line changes in a four digit space.
That example is not ideal, but I couldn't find a recent PR which had a successful CI run and was a NO-OP. Maybe just create a few empty PRs, make the CI runs succeed and then you will have a few clear reports which show you exactly which lines are not stable.
Generally we can only consider the coverage report stable if that page reports 0 changes for runs which do not change anything. Otherwise, these numbers are misleading and will confuse the PR authors if we enable the publishing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services