You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/01/09 11:08:07 UTC

[GitHub] chetanmeh commented on issue #3161: Add type property to entity documents

chetanmeh commented on issue #3161: Add type property to entity documents
URL: https://github.com/apache/incubator-openwhisk/issues/3161#issuecomment-356253774
 
 
   @rabbah  Opened PR #3162 with initial approach which uses reflection to determine the type property value based on entity class name. This approach has potential issues like
   
   # Add slight overhead due to use of reflection
   # The type value may change in entity class name is refactored later causing backwarnd compatibility issue
   
   Other possible approaches can be
   
   # Add type property explicitly with each type
   # OR derive the property in `WhiskDocument` based on same logic as used in CouchDb views
   
   Let me know which approach should be taken

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services