You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/10/08 15:59:56 UTC

[GitHub] [ignite] mrk-andreev opened a new pull request #8336: IGNITE-13531: Code cleanup in Util classes

mrk-andreev opened a new pull request #8336:
URL: https://github.com/apache/ignite/pull/8336


   - add a private constructorto Util classes in ignite ml.
   - add Serializable to Blas class
   - add final modifier to static inner fields in utils class
   - inefficient use of keySet iterator instead of entrySet
   - can be replaced with single Arrays.fill method call
   
   Issue: https://issues.apache.org/jira/browse/IGNITE-13531


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] zaleslaw commented on pull request #8336: IGNITE-13531 [ML]: Code cleanup in Util classes

Posted by GitBox <gi...@apache.org>.

zaleslaw commented on pull request #8336:
URL: https://github.com/apache/ignite/pull/8336#issuecomment-721630145


   LGTM!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] zaleslaw merged pull request #8336: IGNITE-13531 [ML]: Code cleanup in Util classes

Posted by GitBox <gi...@apache.org>.

zaleslaw merged pull request #8336:
URL: https://github.com/apache/ignite/pull/8336


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org