You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/05/27 20:32:54 UTC

Review Request 34724: Doxygen enhancements

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34724/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Joerg Schad, and Marco Massenzio.


Repository: mesos


Description
-------

Removes latex generation, enables class index and docset's (for use in, for example Dash)


Diffs
-----

  Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf 

Diff: https://reviews.apache.org/r/34724/diff/


Testing
-------


Thanks,

Niklas Nielsen


Re: Review Request 34724: Doxygen enhancements

Posted by Niklas Nielsen <ni...@qni.dk>.

> On May 27, 2015, 4:24 p.m., Marco Massenzio wrote:
> > Doxyfile, line 833
> > <https://reviews.apache.org/r/34724/diff/1/?file=972987#file972987line833>
> >
> >     Apache Mesos Docs, maybe?

Great point! Will change that before committing.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34724/#review85460
-----------------------------------------------------------


On May 27, 2015, 11:38 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34724/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 11:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joerg Schad, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes latex generation, enables class index and docset's (for use in, for example Dash)
> 
> 
> Diffs
> -----
> 
>   Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf 
> 
> Diff: https://reviews.apache.org/r/34724/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> class index
>   https://reviews.apache.org/media/uploaded/files/2015/05/27/97de9c4f-dba9-4fc0-bec2-7c2a918a341b__Screen_Shot_2015-05-27_at_11.38.12_AM.png
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 34724: Doxygen enhancements

Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34724/#review85460
-----------------------------------------------------------

Ship it!


Awesome!


Doxyfile
<https://reviews.apache.org/r/34724/#comment137038>

    Apache Mesos Docs, maybe?


- Marco Massenzio


On May 27, 2015, 6:38 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34724/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 6:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joerg Schad, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes latex generation, enables class index and docset's (for use in, for example Dash)
> 
> 
> Diffs
> -----
> 
>   Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf 
> 
> Diff: https://reviews.apache.org/r/34724/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> class index
>   https://reviews.apache.org/media/uploaded/files/2015/05/27/97de9c4f-dba9-4fc0-bec2-7c2a918a341b__Screen_Shot_2015-05-27_at_11.38.12_AM.png
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 34724: Doxygen enhancements

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34724/#review85529
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34724]

All tests passed.

- Mesos ReviewBot


On May 27, 2015, 6:38 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34724/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 6:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joerg Schad, and Marco Massenzio.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes latex generation, enables class index and docset's (for use in, for example Dash)
> 
> 
> Diffs
> -----
> 
>   Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf 
> 
> Diff: https://reviews.apache.org/r/34724/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> class index
>   https://reviews.apache.org/media/uploaded/files/2015/05/27/97de9c4f-dba9-4fc0-bec2-7c2a918a341b__Screen_Shot_2015-05-27_at_11.38.12_AM.png
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 34724: Doxygen enhancements

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34724/
-----------------------------------------------------------

(Updated May 27, 2015, 11:38 a.m.)


Review request for mesos, Ben Mahler, Joerg Schad, and Marco Massenzio.


Changes
-------

Added example of class index


Repository: mesos


Description
-------

Removes latex generation, enables class index and docset's (for use in, for example Dash)


Diffs
-----

  Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf 

Diff: https://reviews.apache.org/r/34724/diff/


Testing
-------


File Attachments (updated)
----------------

class index
  https://reviews.apache.org/media/uploaded/files/2015/05/27/97de9c4f-dba9-4fc0-bec2-7c2a918a341b__Screen_Shot_2015-05-27_at_11.38.12_AM.png


Thanks,

Niklas Nielsen