You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/02 23:01:41 UTC
Review Request 28608: Allowed slave to create and link persistent
volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28608/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2031
https://issues.apache.org/jira/browse/MESOS-2031
Repository: mesos-git
Description
-------
Allowed slave to create and link persistent volumes.
Diffs
-----
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5
Diff: https://reviews.apache.org/r/28608/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 28608: Allowed slave to create and link persistent
volumes.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28608/#review70645
-----------------------------------------------------------
Replaced by https://reviews.apache.org/r/30510/ (do that in the containerizer).
- Jie Yu
On Dec. 2, 2014, 10:01 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28608/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 10:01 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2031
> https://issues.apache.org/jira/browse/MESOS-2031
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed slave to create and link persistent volumes.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
> src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5
>
> Diff: https://reviews.apache.org/r/28608/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28608: Allowed slave to create and link persistent
volumes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28608/#review67118
-----------------------------------------------------------
Hm.. per my comment below, it looks like this depends on r/28809 (rather than the other way around).
src/slave/slave.hpp
<https://reviews.apache.org/r/28608/#comment110944>
Given this comment, does this approach work for the existing Docker containerizer? Or will the symlinks become invalid?
src/slave/slave.cpp
<https://reviews.apache.org/r/28608/#comment110945>
It seems a bit odd to be preparing these blindly, without validating that we first know about these resources.
Is there any reason that this review comes before r/28809/? It looks like it should come afterwards.
src/slave/slave.cpp
<https://reviews.apache.org/r/28608/#comment110946>
Here and elsewhere where you're CHECKing these things, we might want to have a comment saying that the master validates these things.
src/slave/slave.cpp
<https://reviews.apache.org/r/28608/#comment110941>
Is this being validated in the master to prevent this check from failing in the slave?
src/slave/slave.cpp
<https://reviews.apache.org/r/28608/#comment110943>
Do you need to be CHECKing that the container path is non-empty, and has valid characters for a directory name? And are we catching these things in the master?
- Ben Mahler
On Dec. 2, 2014, 10:01 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28608/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 10:01 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2031
> https://issues.apache.org/jira/browse/MESOS-2031
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Allowed slave to create and link persistent volumes.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
> src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5
>
> Diff: https://reviews.apache.org/r/28608/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 28608: Allowed slave to create and link persistent
volumes.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28608/#review65754
-----------------------------------------------------------
src/slave/slave.hpp
<https://reviews.apache.org/r/28608/#comment108995>
s/wanna/want to/
src/slave/slave.hpp
<https://reviews.apache.org/r/28608/#comment108996>
s/wanna/want to/
src/slave/slave.cpp
<https://reviews.apache.org/r/28608/#comment108997>
Should we check that the link actually points where we expect?
- Adam B
On Dec. 2, 2014, 2:01 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28608/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 2:01 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2031
> https://issues.apache.org/jira/browse/MESOS-2031
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Allowed slave to create and link persistent volumes.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
> src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5
>
> Diff: https://reviews.apache.org/r/28608/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>