You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/10 02:48:40 UTC

[GitHub] [incubator-superset] betodealmeida opened a new pull request #7266: Do not add tag to non-saved objects

betodealmeida opened a new pull request #7266: Do not add tag to non-saved objects
URL: https://github.com/apache/incubator-superset/pull/7266
 
 
   ##### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR prevents people from adding tags to unsaved charts, and in case those tags have been created in the past it prevents them from showing up in new charts.
   
   <!-- ##### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   <!-- ##### TEST PLAN -->
   <!--- What steps were taken to verify -->
   
   ##### ADDITIONAL INFORMATION
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> 
   <!--- Check any relevant boxes with "x" -->
       [ ] Has associated issue:
       [ ] Changes UI
       [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.
       [ ] Introduces new feature or API
       [ ] Removes existing feature or API
       [X] Fixes bug
       [ ] Refactors code
       [ ] Adds test(s)
   
   ##### REVIEWERS
   
   @xtinec @datability-io @khtruong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org