[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10744: Add description field to metrics in Pinot

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #10744:
URL: https://github.com/apache/pinot/pull/10744#discussion_r1187798247


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -101,11 +101,16 @@ public enum ServerMeter implements AbstractMetrics.Meter {
   private final String _meterName;
   private final String _unit;
   private final boolean _global;
+  private final String _description;
 
   ServerMeter(String unit, boolean global) {
+    this(unit, global, "");
+  }

Review Comment:
   Nit: new line



##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -54,10 +54,16 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
   private final String _unit;
   private final boolean _global;
 
+  private final String _description;
+
   ServerGauge(String unit, boolean global) {
+    this(unit, global, "");
+  }

Review Comment:
   nit: new line



##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMetrics.java:
##########
@@ -79,4 +79,10 @@ protected ServerMeter[] getMeters() {
   protected ServerGauge[] getGauges() {
     return ServerGauge.values();
   }
+
+  public static void main(String[] args) {

Review Comment:
   Remove this 



##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java:
##########
@@ -67,4 +76,16 @@ public String getTimerName() {
   public boolean isGlobal() {
     return _global;
   }
+
+  @Override
+  public String getDescription() {
+    return _description;
+  }
+
+  public static void main(String[] args) {

Review Comment:
   Remove this 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org