You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2018/10/17 22:51:00 UTC

[jira] [Commented] (CALCITE-2629) Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope

    [ https://issues.apache.org/jira/browse/CALCITE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654326#comment-16654326 ] 

Julian Hyde commented on CALCITE-2629:
--------------------------------------

It seems that the {{schemaNames}} field was used until CALCITE-1208 was fixed, and now is just assigned. Can you do some research and see which test cases (if any) exercise that functionality? It's possible that in commit 0938c7b6d7 the code moved elsewhere. If so the field and its initializer can be removed.

> Unnecessary call to CatalogReader#getAllSchemaObjects in CatalogScope
> ---------------------------------------------------------------------
>
>                 Key: CALCITE-2629
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2629
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>            Priority: Minor
>
> CatalogScope constructor does a call to CatalogReader#getAllSchemaObjects and store its result into a private field which has no accessor. This call is actually expensive in our system, and is causing some performance issue during planning



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)