[jira] [Commented] (FLINK-20098) Don't add flink-connector-files to flink-dist, make dependencies explicit

["Thomas Weise (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-20098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273900#comment-17273900 ] 

Thomas Weise commented on FLINK-20098:
--------------------------------------

Glad to see that the connector dependency was moved back to application land. Depending on how Flink is distributed it can be  very difficult to patch dependencies in lib and whenever possible I prefer to see those as part of the application classpath.

 

> Don't add flink-connector-files to flink-dist, make dependencies explicit
> -------------------------------------------------------------------------
>
>                 Key: FLINK-20098
>                 URL: https://issues.apache.org/jira/browse/FLINK-20098
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / DataStream
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.12.0
>
>
> We currently add both {{flink-connector-files}} and {{flink-connector-base}} to {{flink-dist}}. 
> This implies, that users should use the dependency like this:
> {code}
> <dependency>
> 	<groupId>org.apache.flink</groupId>
> 	<artifactId>flink-connector-files</artifactId>
> 	<version>${project.version}</version>
> 	<scope>provided</scope>
> </dependency>
> {code}
> which differs from other connectors where users don't need to specify {{<scope>provided</scope>}}.
> Also, {{flink-connector-files}} has {{flink-connector-base}} as a provided dependency, which means that examples that use this dependency will not run out-of-box in IntelliJ because transitive provided dependencies will not be considered.
> I propose to just remove the dependencies from {{flink-dist}} and let users use the File Connector like any other connector.
> I believe the initial motivation for "providing" the File Connector in {{flink-dist}} was to allow us to use the File Connector under the hood in methods such as {{StreamExecutionEnvironment.readFile(...)}}. We could decide to deprecate and remove those methods or re-add the File Connector as an explicit (non-provided) dependency again in the future.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)