You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 01:02:32 UTC
Review Request 70091: WIP: Added tox invocation to test stage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
This patch also removes a redundant printout which was not properly
synchronized with the test execution's output and would have appeared at
the incorrect time.
Diffs
-----
src/python/cli_new/bin/mesos-cli-tests 9157d4970e2d6954c65d490ce7c4cffd7541e2b9
src/python/cli_new/pip-requirements.txt 663f774786989d93d20e005e3c3eeeffc439068e
src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6
Diff: https://reviews.apache.org/r/70091/diff/1/
Testing
-------
This path currently triggers MESOS-9629 via `CLITests`,
```
$ ctest -R CLI --verbose
UpdateCTestConfiguration from :/home/bbannier/src/mesos/_/DartConfiguration.tcl
UpdateCTestConfiguration from :/home/bbannier/src/mesos/_/DartConfiguration.tcl
Test project /home/bbannier/src/mesos/_
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 4
Start 4: CLITests
4: Test command: /usr/bin/bash "run_cli_tests.sh"
4: Test timeout computed to be: 10000000
4: py3-lint installed: altgraph==0.16.1,astroid==2.0.4,atomicwrites==1.3.0,attrs==18.2.0,backports.functools-lru-cache==1.2.1,certifi==2018.11.29,chardet==3.0.4,configparser==3.5.0,coverage==4.5.2,docopt==0.6.2,future==0.17.1,idna==2.7,isort==4.2.5,kazoo==2.5.0,lazy-object-proxy==1.2.2,macholib==1.11,mccabe==0.5.2,-e git+https://gitbox.apache.org/repos/asf/mesos.git@5c12edd80c3cbd84c98e264e87761c1eccacd35d#egg=mesos&subdirectory=src/python/lib,mock==2.0.0,more-itertools==6.0.0,parse==1.8.0,pbr==5.1.3,pefile==2018.8.8,pluggy==0.9.0,py==1.8.0,Pygments==2.1.3,PyInstaller==3.4,pylint==2.3.0,pytest==3.7.3,pytest-cov==2.5.1,requests==2.19.1,six==1.10.0,tenacity==4.12.0,toml==0.9.2,tox==3.2.1,typed-ast==1.3.1,ujson==1.35,urllib3==1.23,virtualenv==16.4.3,wrapt==1.10.8
4: py3-lint runtests: PYTHONHASHSEED='4128305149'
4: py3-lint runtests: commands[0] | pylint --score=n --rcfile=../../../support/pylint.config lib/cli tests
4: ************* Module tests.main
4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.config) (cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.plugins -> cli.plugins.base) (cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.task) (cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.tests) (cyclic-import)
4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.agent) (cyclic-import)
4: ERROR: InvocationError for command '/home/bbannier/src/mesos/src/python/cli_new/.tox/py3-lint/bin/pylint --score=n --rcfile=../../../support/pylint.config lib/cli tests' (exited with code 8)
4: ___________________________________ summary ____________________________________
4: ERROR: py3-lint: commands failed
1/1 Test #4: CLITests .........................***Failed 5.91 sec
0% tests passed, 1 tests failed out of 1
Total Test time (real) = 5.92 sec
The following tests FAILED:
4 - CLITests (Failed)
Errors while running CTest
```
Thanks,
Benjamin Bannier
Re: Review Request 70091: WIP: Added tox invocation to test stage.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/#review213368
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70088, 70089, 70090, 70092, 70091]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 2, 2019, 5:02 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70091/
> -----------------------------------------------------------
>
> (Updated March 2, 2019, 5:02 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch also removes a redundant printout which was not properly
> synchronized with the test execution's output and would have appeared at
> the incorrect time.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/mesos-cli-tests 9157d4970e2d6954c65d490ce7c4cffd7541e2b9
> src/python/cli_new/pip-requirements.txt 663f774786989d93d20e005e3c3eeeffc439068e
> src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6
>
>
> Diff: https://reviews.apache.org/r/70091/diff/1/
>
>
> Testing
> -------
>
> This path currently triggers MESOS-9629 via `CLITests`,
> ```
> $ ctest -R CLI --verbose
> UpdateCTestConfiguration from :/home/bbannier/src/mesos/_/DartConfiguration.tcl
> UpdateCTestConfiguration from :/home/bbannier/src/mesos/_/DartConfiguration.tcl
> Test project /home/bbannier/src/mesos/_
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 4
> Start 4: CLITests
>
> 4: Test command: /usr/bin/bash "run_cli_tests.sh"
> 4: Test timeout computed to be: 10000000
> 4: py3-lint installed: altgraph==0.16.1,astroid==2.0.4,atomicwrites==1.3.0,attrs==18.2.0,backports.functools-lru-cache==1.2.1,certifi==2018.11.29,chardet==3.0.4,configparser==3.5.0,coverage==4.5.2,docopt==0.6.2,future==0.17.1,idna==2.7,isort==4.2.5,kazoo==2.5.0,lazy-object-proxy==1.2.2,macholib==1.11,mccabe==0.5.2,-e git+https://gitbox.apache.org/repos/asf/mesos.git@5c12edd80c3cbd84c98e264e87761c1eccacd35d#egg=mesos&subdirectory=src/python/lib,mock==2.0.0,more-itertools==6.0.0,parse==1.8.0,pbr==5.1.3,pefile==2018.8.8,pluggy==0.9.0,py==1.8.0,Pygments==2.1.3,PyInstaller==3.4,pylint==2.3.0,pytest==3.7.3,pytest-cov==2.5.1,requests==2.19.1,six==1.10.0,tenacity==4.12.0,toml==0.9.2,tox==3.2.1,typed-ast==1.3.1,ujson==1.35,urllib3==1.23,virtualenv==16.4.3,wrapt==1.10.8
> 4: py3-lint runtests: PYTHONHASHSEED='4128305149'
> 4: py3-lint runtests: commands[0] | pylint --score=n --rcfile=../../../support/pylint.config lib/cli tests
> 4: ************* Module tests.main
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.config) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.plugins -> cli.plugins.base) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.task) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.tests) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.agent) (cyclic-import)
> 4: ERROR: InvocationError for command '/home/bbannier/src/mesos/src/python/cli_new/.tox/py3-lint/bin/pylint --score=n --rcfile=../../../support/pylint.config lib/cli tests' (exited with code 8)
> 4: ___________________________________ summary ____________________________________
> 4: ERROR: py3-lint: commands failed
> 1/1 Test #4: CLITests .........................***Failed 5.91 sec
>
> 0% tests passed, 1 tests failed out of 1
>
> Total Test time (real) = 5.92 sec
>
> The following tests FAILED:
> 4 - CLITests (Failed)
> Errors while running CTest
> ```
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70091: Added tox invocation to test stage.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/#review213375
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On March 3, 2019, 6:09 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70091/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 6:09 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Bugs: MESOS-9628
> https://issues.apache.org/jira/browse/MESOS-9628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch also removes a redundant printout which was not properly
> synchronized with the test execution's output and would have appeared at
> the incorrect time.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/mesos-cli-tests 9157d4970e2d6954c65d490ce7c4cffd7541e2b9
> src/python/cli_new/pip-requirements.txt 663f774786989d93d20e005e3c3eeeffc439068e
> src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6
>
>
> Diff: https://reviews.apache.org/r/70091/diff/1/
>
>
> Testing
> -------
>
> `ctest -R CLI --verbose`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70091: Added tox invocation to test stage.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/
-----------------------------------------------------------
(Updated March 3, 2019, 6:09 p.m.)
Review request for mesos and Armand Grillet.
Summary (updated)
-----------------
Added tox invocation to test stage.
Repository: mesos
Description
-------
This patch also removes a redundant printout which was not properly
synchronized with the test execution's output and would have appeared at
the incorrect time.
Diffs
-----
src/python/cli_new/bin/mesos-cli-tests 9157d4970e2d6954c65d490ce7c4cffd7541e2b9
src/python/cli_new/pip-requirements.txt 663f774786989d93d20e005e3c3eeeffc439068e
src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6
Diff: https://reviews.apache.org/r/70091/diff/1/
Testing (updated)
-------
`ctest -R CLI --verbose`
Thanks,
Benjamin Bannier
Re: Review Request 70091: WIP: Added tox invocation to test stage.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70091/#review213360
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70088, 70089, 70090, 70092, 70091]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70091/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:02 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch also removes a redundant printout which was not properly
> synchronized with the test execution's output and would have appeared at
> the incorrect time.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/mesos-cli-tests 9157d4970e2d6954c65d490ce7c4cffd7541e2b9
> src/python/cli_new/pip-requirements.txt 663f774786989d93d20e005e3c3eeeffc439068e
> src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6
>
>
> Diff: https://reviews.apache.org/r/70091/diff/1/
>
>
> Testing
> -------
>
> This path currently triggers MESOS-9629 via `CLITests`,
> ```
> $ ctest -R CLI --verbose
> UpdateCTestConfiguration from :/home/bbannier/src/mesos/_/DartConfiguration.tcl
> UpdateCTestConfiguration from :/home/bbannier/src/mesos/_/DartConfiguration.tcl
> Test project /home/bbannier/src/mesos/_
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 4
> Start 4: CLITests
>
> 4: Test command: /usr/bin/bash "run_cli_tests.sh"
> 4: Test timeout computed to be: 10000000
> 4: py3-lint installed: altgraph==0.16.1,astroid==2.0.4,atomicwrites==1.3.0,attrs==18.2.0,backports.functools-lru-cache==1.2.1,certifi==2018.11.29,chardet==3.0.4,configparser==3.5.0,coverage==4.5.2,docopt==0.6.2,future==0.17.1,idna==2.7,isort==4.2.5,kazoo==2.5.0,lazy-object-proxy==1.2.2,macholib==1.11,mccabe==0.5.2,-e git+https://gitbox.apache.org/repos/asf/mesos.git@5c12edd80c3cbd84c98e264e87761c1eccacd35d#egg=mesos&subdirectory=src/python/lib,mock==2.0.0,more-itertools==6.0.0,parse==1.8.0,pbr==5.1.3,pefile==2018.8.8,pluggy==0.9.0,py==1.8.0,Pygments==2.1.3,PyInstaller==3.4,pylint==2.3.0,pytest==3.7.3,pytest-cov==2.5.1,requests==2.19.1,six==1.10.0,tenacity==4.12.0,toml==0.9.2,tox==3.2.1,typed-ast==1.3.1,ujson==1.35,urllib3==1.23,virtualenv==16.4.3,wrapt==1.10.8
> 4: py3-lint runtests: PYTHONHASHSEED='4128305149'
> 4: py3-lint runtests: commands[0] | pylint --score=n --rcfile=../../../support/pylint.config lib/cli tests
> 4: ************* Module tests.main
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.config) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli -> cli.plugins -> cli.plugins.base) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.task) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.tests) (cyclic-import)
> 4: tests/main.py:1:0: R0401: Cyclic import (cli.tests -> cli.tests.agent) (cyclic-import)
> 4: ERROR: InvocationError for command '/home/bbannier/src/mesos/src/python/cli_new/.tox/py3-lint/bin/pylint --score=n --rcfile=../../../support/pylint.config lib/cli tests' (exited with code 8)
> 4: ___________________________________ summary ____________________________________
> 4: ERROR: py3-lint: commands failed
> 1/1 Test #4: CLITests .........................***Failed 5.91 sec
>
> 0% tests passed, 1 tests failed out of 1
>
> Total Test time (real) = 5.92 sec
>
> The following tests FAILED:
> 4 - CLITests (Failed)
> Errors while running CTest
> ```
>
>
> Thanks,
>
> Benjamin Bannier
>
>