You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lsergio (via GitHub)" <gi...@apache.org> on 2024/01/30 12:45:18 UTC

[PR] feat(#5103): Adding nodeSelector to the operator helm chart [camel-k]

lsergio opened a new pull request, #5122:
URL: https://github.com/apache/camel-k/pull/5122

   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   It is now possible to set the operator nodeSelector in the helm values file.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(#5103): Adding nodeSelector to the operator helm chart [camel-k]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #5122:
URL: https://github.com/apache/camel-k/pull/5122#discussion_r1471277074


##########
helm/camel-k/README.md:
##########
@@ -15,7 +15,6 @@ To install the chart, first add the Camel K repository:
 
 ```bash
 $ helm repo add camel-k https://apache.github.io/camel-k/charts
-```

Review Comment:
   Maybe this is required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(#5103): Adding nodeSelector to the operator helm chart [camel-k]

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #5122:
URL: https://github.com/apache/camel-k/pull/5122#discussion_r1471185213


##########
helm/camel-k/values.yaml:
##########
@@ -28,6 +28,7 @@ operator:
   resources: {}
   securityContext: {}
   tolerations: []
+  nodeSelector: {}

Review Comment:
   This should be added to the documentation here: https://github.com/apache/camel-k/blob/a98dec1f8f260c2e478543c1ed3f19113c0cc5d2/helm/camel-k/README.md?plain=1#L107



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(#5103): Adding nodeSelector to the operator helm chart [camel-k]

Posted by "lsergio (via GitHub)" <gi...@apache.org>.
lsergio commented on code in PR #5122:
URL: https://github.com/apache/camel-k/pull/5122#discussion_r1471203391


##########
helm/camel-k/values.yaml:
##########
@@ -28,6 +28,7 @@ operator:
   resources: {}
   securityContext: {}
   tolerations: []
+  nodeSelector: {}

Review Comment:
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org