You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/18 15:44:00 UTC
[GitHub] [dolphinscheduler] insist777 opened a new pull request, #11551: [Improvement] Dependent tasks support dependent policies
insist777 opened a new pull request, #11551:
URL: https://github.com/apache/dolphinscheduler/pull/11551
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
Dependent tasks support dependent policies
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Dependent tasks support dependent policies [dolphinscheduler]
Posted by "insist777 (via GitHub)" <gi...@apache.org>.
insist777 closed pull request #11551: [Improvement] Dependent tasks support dependent policies
URL: https://github.com/apache/dolphinscheduler/pull/11551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11551: [Improvement] Dependent tasks support dependent policies
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #11551:
URL: https://github.com/apache/dolphinscheduler/pull/11551#discussion_r949725556
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/DependentParameters.java:
##########
@@ -21,11 +21,13 @@
import org.apache.dolphinscheduler.plugin.task.api.model.DependentTaskModel;
import java.util.List;
+import java.util.Map;
public class DependentParameters extends AbstractParameters {
private List<DependentTaskModel> dependTaskList;
private DependentRelation relation;
+ private Map<String, Object> otherParams;
Review Comment:
Could you please describe what is otherParams? And why if the dependent is not exist, we still need to set the otherParams? this is strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] insist777 commented on a diff in pull request #11551: [Improvement] Dependent tasks support dependent policies
Posted by GitBox <gi...@apache.org>.
insist777 commented on code in PR #11551:
URL: https://github.com/apache/dolphinscheduler/pull/11551#discussion_r949770727
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/DependentParameters.java:
##########
@@ -21,11 +21,13 @@
import org.apache.dolphinscheduler.plugin.task.api.model.DependentTaskModel;
import java.util.List;
+import java.util.Map;
public class DependentParameters extends AbstractParameters {
private List<DependentTaskModel> dependTaskList;
private DependentRelation relation;
+ private Map<String, Object> otherParams;
Review Comment:
This is another parameter, which can be extended later; In addition, if the dependent does not exist, it will not be set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org