You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2021/01/19 06:28:20 UTC
[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16949 )
Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks
......................................................................
IMPALA-9224 (part 1): Blacklist nodes with faulty disks
This patch extends blacklist functionality by adding executor node to
blacklist if a query fails caused by disk failure during spill-to-disk.
Also adds debug action to simulate disk write error and adds new
test cases for blacklist and query-retry.
Testing:
- Passed new test cases.
- Passed exhaustive test.
Change-Id: I04bfcb7f2e0b1ef24a5b4350f270feecd8c47437
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/query-state.cc
M be/src/runtime/tmp-file-mgr-internal.h
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M common/protobuf/control_service.proto
M common/thrift/generate_error_codes.py
M tests/custom_cluster/test_blacklist.py
M tests/custom_cluster/test_query_retries.py
12 files changed, 399 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/16949/2
--
To view, visit http://gerrit.cloudera.org:8080/16949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I04bfcb7f2e0b1ef24a5b4350f270feecd8c47437
Gerrit-Change-Number: 16949
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>