You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/10/16 18:44:07 UTC
[GitHub] [incubator-teaclave-sgx-sdk] mjquinlan opened a new pull request #273: Added conditional compilation for musl targets
mjquinlan opened a new pull request #273:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273
Allows building statically linked applications. This is useful for organizations needing to extend backwards compatibility to older OS releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] mjquinlan commented on pull request #273: Added conditional compilation for musl targets
Posted by GitBox <gi...@apache.org>.
mjquinlan commented on pull request #273:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710429444
Thanks! Let me add some documentation in a second commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] mssun commented on pull request #273: Added conditional compilation for musl targets
Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #273:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-918550411
@mjquinlan Thank you so much! I'm wondering if there's any update on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] mssun commented on pull request #273: Added conditional compilation for musl targets
Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #273:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710415285
Looks good to me. I think this can be documented somewhere so that other people may also interested.
@dingelish, what do you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] dingelish commented on pull request #273: Added conditional compilation for musl targets
Posted by GitBox <gi...@apache.org>.
dingelish commented on pull request #273:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710422202
sgtm :-) better if comes along with some description by either code comments or readme.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr commented on a change in pull request #273: Added conditional compilation for musl targets
Posted by GitBox <gi...@apache.org>.
volcano0dr commented on a change in pull request #273:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#discussion_r507485368
##########
File path: sgx_urts/src/fd.rs
##########
@@ -217,6 +219,23 @@ pub extern "C" fn u_fcntl_arg1_ocall(
ret
}
+#[cfg(all(target_env="musl", not(target_env="")))]
+#[no_mangle]
+pub extern "C" fn u_ioctl_arg0_ocall(error: * mut c_int,
+ fd: c_int,
+ request: c_int) -> c_int {
+ let mut errno = 0;
+ let ret = unsafe { libc::ioctl(fd, request) };
Review comment:
I suggest adding conditional compilation option in this line `(let ret = unsafe { libc::ioctl(fd, request) }).` Because the function prototype has not changed, I think there is no need to define a function for the musl target separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org