You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "bvdberg (via GitHub)" <gi...@apache.org> on 2023/05/10 12:47:00 UTC
[GitHub] [mynewt-nimble] bvdberg opened a new pull request, #1497: porting/FreeRTOS: fix IRQ priority
bvdberg opened a new pull request, #1497:
URL: https://github.com/apache/mynewt-nimble/pull/1497
FreeRTOS assumes a max irq priority for IRQs that are allowed to do system calls. This is set to 5 by default, so we use the highest allowed for the Radio.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1497: porting/FreeRTOS: fix IRQ priority
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek merged PR #1497:
URL: https://github.com/apache/mynewt-nimble/pull/1497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1497: porting/FreeRTOS: fix IRQ priority
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1497:
URL: https://github.com/apache/mynewt-nimble/pull/1497#discussion_r1192028079
##########
nimble/drivers/nrf5x/src/ble_phy.c:
##########
@@ -1657,7 +1657,11 @@ ble_phy_init(void)
/* Set isr in vector table and enable interrupt */
#ifndef RIOT_VERSION
Review Comment:
lets make this explicit to FreeRTOS (in long term we need to redesign this a bit anyway)
#if FREERTOS (or whatever it uses)
NVIC_SetPriority(RADIO_IRQn, 5);
#else
NVIC_SetPriority(RADIO_IRQn, 0);
#endif
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] bvdberg commented on pull request #1497: porting/FreeRTOS: fix IRQ priority
Posted by "bvdberg (via GitHub)" <gi...@apache.org>.
bvdberg commented on PR #1497:
URL: https://github.com/apache/mynewt-nimble/pull/1497#issuecomment-1545374517
Sure, changed as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org