[jira] [Commented] (HBASE-16824) Writer.flush() can be called on already closed streams in WAL roll

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576831#comment-15576831 ] 

stack commented on HBASE-16824:
-------------------------------

Nice one (again) Enis. I owe you a beer.

Fix looks good but we have to keep a running counter? Would be good to keep this path obstacle-free. We can't just look at where the SyncRunners are at roll time and wait till they all have stalled w/ syncs cleared this.syncFutures.length <= 0? (maybe not possible -- and that is why you have this counter signalling). If you've already tried to do this and this is what you ended up w/, +1.

On commit fix this:

345	      // Wait on the safe point to be achieved. Send in a sync in case nothing has hit THE

... the capitalized THE



> Writer.flush() can be called on already closed streams in WAL roll
> ------------------------------------------------------------------
>
>                 Key: HBASE-16824
>                 URL: https://issues.apache.org/jira/browse/HBASE-16824
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Atri Sharma
>            Assignee: Enis Soztutar
>         Attachments: hbase-16824_v1.patch
>
>
> In https://issues.apache.org/jira/browse/HBASE-12074, we hit an error if an async thread calls flush on a WAL record already closed as the WAL is being rotated. This JIRA investigates if setting the new WAL record path as the first operation during WAL rotation will fix the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)