You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/07/30 04:10:24 UTC
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s opened a new pull request #42: [YUNIKORN-760] Fix build failures on clean checkout
wilfred-s opened a new pull request #42:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42
### What is this PR for?
The update of the proto compiler caused the build to fail on a clean
checkout.
The new protoc uses a different plugin setup and stricter rules around
the proto content. gRPC generations has been removed at this point as it
is not used. Simplified the protoc command line.
Make clean and clobber consistentcy changes.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-760
### How should this be tested?
Clean checkout of the repo and run make
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on pull request #42: [YUNIKORN-760] Fix build failures on clean checkout
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #42:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42#issuecomment-890688318
I seem to have a problem adding @manirajv06 as a reviewer. He should be on the committer list but is not on the committer list in github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on pull request #42: [YUNIKORN-760] Fix build failures on clean checkout
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #42:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42#issuecomment-890687930
No it is a full replacement of #40. #40 does not fix most of the problems. It allows us to build if you have most of the tools already in your environment. It does just fix a clean build from scratch. Just fixing that one specific issue and leaving all the other problems around is not the right solution.
@updown321 can you please check this too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei merged pull request #42: [YUNIKORN-760] Fix build failures on clean checkout
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #42:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on pull request #42: [YUNIKORN-760] Fix build failures on clean checkout
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #42:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42#issuecomment-890044282
hi @wilfred-s thanks for fixing this up. Is this a superset of #40?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org