You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pig.apache.org by Jarek Cecho <ja...@apache.org> on 2014/03/27 18:46:56 UTC

Review Request 19737: PIG-3830 HiveColumnarLoader throwing FileNotFoundException on Hadoop 2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19737/
-----------------------------------------------------------

Review request for pig.


Bugs: PIG-3830
    https://issues.apache.org/jira/browse/PIG-3830


Repository: pig-git


Description
-------

Attaching patch that:
* Add catch block for the FileNotFound exception to gracefully handle the situation on Hadoop 2.0.
* Fix formatting of the affected method getPartitionKeys. Entire file is not using the usual formatting guidelines that we are using in Pig, so I've fixed at least the method I was changing.
* Added test.output variable to piggybank's build.xml file as it was missing


Diffs
-----

  contrib/piggybank/java/build.xml ebf099d 
  contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/partition/PathPartitioner.java 3bd7fe9 
  contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestHiveColumnarLoader.java b2457b2 

Diff: https://reviews.apache.org/r/19737/diff/


Testing
-------

Added new unit test covering this scenario.


Thanks,

Jarek Cecho