[GitHub] [superset] villebro commented on issue #20159: [SIP-82] - Improving Superset Theming

[GitBox <gi...@apache.org>]

villebro commented on issue #20159:
URL: https://github.com/apache/superset/issues/20159#issuecomment-1135477454

   > > Upgrade Ant Design to the latest version and use CSS variables
   > 
   > This option seems the best to me. We may also benefit from some new components Ant has added.
   
   We're actually in a bad place right now with our current version of AntD (4.9.4):
   - While our current version of AntD appears to work fine with React 16 (we're currently at 16.3.1), it no longer formally supports React 16. So we need to bump React first, and that will require figuring out what to do with all the dependencies we have that haven't yet introduced explicit support for React 17+. So this in itself is a fair bit of work.
   - Our current version of AntD over 18 months old, and bumping it to the current version will likely introduce a fair amount of breaking changes. I remember testing Superset with a more recent version a year ago or so, and it completely broke a lot of components. So this will also need to be done carefully to not introduce regressions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org