You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/06/04 21:03:01 UTC

[jira] [Commented] (CLIMATE-455) utils.reshape_monthly_to_annually should modify a copy of the passed dataset

    [ https://issues.apache.org/jira/browse/CLIMATE-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018016#comment-14018016 ] 

ASF GitHub Bot commented on CLIMATE-455:
----------------------------------------

GitHub user MJJoyce opened a pull request:

    https://github.com/apache/climate/pull/58

    CLIMATE-455 - Update reshape_monthly_to_annually to use copies of data

    - utils.reshape_monthly_to_annually now uses a copy of the passed
      dataset's data instead of the actual dataset.values array.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MJJoyce/climate CLIMATE-455

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 574ee97f3871a3b219f23d999957e509f0a87380
Author: Michael Joyce <jo...@apache.org>
Date:   2014-06-04T18:59:33Z

    CLIMATE-455 - Update reshape_monthly_to_annually to use copies of data
    
    - utils.reshape_monthly_to_annually now uses a copy of the passed
      datasets data instead of the actual datasets.values.

----


> utils.reshape_monthly_to_annually should modify a copy of the passed dataset
> ----------------------------------------------------------------------------
>
>                 Key: CLIMATE-455
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-455
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 0.3-incubating
>         Environment: The utils helpers reshape_monthly_to_annually currently modifies the dataset's values array instead of manipulating a copy of the data and returning that.
>            Reporter: Michael Joyce
>            Assignee: Michael Joyce
>             Fix For: 0.4
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)