You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/04 01:45:22 UTC

[PR] fix(i18n): localize topic route diagnostics payload text [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3066:
URL: https://github.com/apache/rocketmq-dashboard/pull/3066

   ### Summary
   Localize the payload text of the Topic route-diagnostics engine, completing the diagnostics surface after #`topic` route-summary localization (#3035):
   
   - `analyzeTopicRoutes` no longer ships Chinese copy: the `RouteDiagnosticIssue` type drops `title`/`description`, `TopicRouteDiagnostics` drops `statusText`, the `STATUS_TEXT` map and all 14 per-issue zh literals are removed, and `recommendations` now carries `topicRoute.rec.*` keys.
   - The Topic page renders issue titles/descriptions from `topicRoute.issue.*` / `topicRoute.issueDesc.*` keys (code-keyed), status tags from `topicRoute.status.*`, the route-status alert interpolates the translated status, and recommendations are rendered through `t()`; the broker-name prefix separator is language-aware (`:` vs `: `).
   - 45 new keys added to `translations.ts` (statuses, per-code issue titles + descriptions, and 8 recommendation keys).
   
   ### Why
   Even after the summary/headings localization, the alert headline, per-broker issue cards, issue chips and advice bullets still displayed raw Chinese strings straight from the diagnostics module in English mode.
   
   ### Testing
   - `tsc --noEmit` passes (exit 0).
   - `eslint` clean on changed files (0 errors).
   - Vitest: `topicRouteDiagnostics` unit suite (updated to code/key expectations) + full `TopicPage` suite pass (2 files / 20 tests).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(i18n): localize topic route diagnostics payload text [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3066: fix(i18n): localize topic route diagnostics payload text
URL: https://github.com/apache/rocketmq-dashboard/pull/3066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org