Heads-up: change in include-what-you-use behavior

[Adar Lieber-Dembo <ad...@cloudera.com.INVALID>]

I just merged some changes that modify include-what-you-use (IWYU) to
run against the libc++ in thirdparty rather than against the system's
libstdc++. Coupled with some other changes, I expect that running IWYU
on any Linux system should yield the exact same set of recommendations
as when IWYU is run during a precommit build. Ideally, we'll achieve
this determinism on macOS too, but for now I don't expect that to be
the case.

As a reminder, you can run IWYU locally via "make iwyu" (or "ninja
iwyu"), and you can have it automatically perform fixes via "make
iwyu-fix" (or "ninja iwyu-fix"). If you do see any deviation between
local and precommit IWYU behavior, please reply to this thread, or let
me know directly.

Re: Heads-up: change in include-what-you-use behavior

[Alexey Serbin <as...@cloudera.com.INVALID>]

Adar,

Thank you very much for making this possible!

I hope we can address the macOS-related wrinkles soon.


Kind regards,

Alexey



On Fri, Mar 27, 2020 at 1:11 PM Adar Lieber-Dembo <ad...@cloudera.com.invalid>
wrote:

> I just merged some changes that modify include-what-you-use (IWYU) to
> run against the libc++ in thirdparty rather than against the system's
> libstdc++. Coupled with some other changes, I expect that running IWYU
> on any Linux system should yield the exact same set of recommendations
> as when IWYU is run during a precommit build. Ideally, we'll achieve
> this determinism on macOS too, but for now I don't expect that to be
> the case.
>
> As a reminder, you can run IWYU locally via "make iwyu" (or "ninja
> iwyu"), and you can have it automatically perform fixes via "make
> iwyu-fix" (or "ninja iwyu-fix"). If you do see any deviation between
> local and precommit IWYU behavior, please reply to this thread, or let
> me know directly.
>