You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/19 04:17:02 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #9619: MINOR: Reduce sends created by `SendBuilder`

hachikuji commented on a change in pull request #9619:
URL: https://github.com/apache/kafka/pull/9619#discussion_r526583778



##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java
##########
@@ -39,6 +42,7 @@
  */
 public class SendBuilder implements Writable {
     private final Queue<Send> sends = new ArrayDeque<>();
+    private final List<ByteBuffer> buffers = new ArrayList<>();

Review comment:
       Oh, just because `MultiRecordsSend` needs a Queue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org