[jira] [Commented] (HDFS-7922) ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391707#comment-14391707 ] 

Colin Patrick McCabe commented on HDFS-7922:
--------------------------------------------

Hi [~rakeshr], I agree that the test failure looks unrelated.  I was unable to reproduce it locally.

+1.  Committed to 2.8.  Thanks again.

> ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors
> ---------------------------------------------------------------------
>
>                 Key: HDFS-7922
>                 URL: https://issues.apache.org/jira/browse/HDFS-7922
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: 001-HDFS-7922.patch, 002-HDFS-7922.patch, 003-HDFS-7922.patch, 004-HDFS-7922.patch
>
>
> ShortCircuitCache has the following executors. It would be good to shutdown these pools during ShortCircuitCache#close to avoid leaks.
> {code}
>   /**
>    * The executor service that runs the cacheCleaner.
>    */
>   private final ScheduledThreadPoolExecutor cleanerExecutor
>   = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
>           setDaemon(true).setNameFormat("ShortCircuitCache_Cleaner").
>           build());
>   /**
>    * The executor service that runs the cacheCleaner.
>    */
>   private final ScheduledThreadPoolExecutor releaserExecutor
>       = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
>           setDaemon(true).setNameFormat("ShortCircuitCache_SlotReleaser").
>           build());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)