You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/09 11:25:01 UTC

[GitHub] [airflow] krisgeus opened a new pull request #7663: [AIRFLOW-6997] Make sure worker pods initcontainers obtain env vars f…

krisgeus opened a new pull request #7663: [AIRFLOW-6997] Make sure worker pods initcontainers obtain env vars f…
URL: https://github.com/apache/airflow/pull/7663
 
 
   …rom config
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] BasPH commented on a change in pull request #7663: [AIRFLOW-6997] Fix worker pods initcontainers

Posted by GitBox <gi...@apache.org>.
BasPH commented on a change in pull request #7663: [AIRFLOW-6997] Fix worker pods initcontainers
URL: https://github.com/apache/airflow/pull/7663#discussion_r393262661
 
 

 ##########
 File path: airflow/contrib/kubernetes/worker_configuration.py
 ##########
 @@ -73,6 +73,13 @@ def _get_init_containers(self):
             'name': 'GIT_SYNC_REV',
             'value': self.kube_config.git_sync_rev
         }]
+
+        for env_var_name, env_var_val in six.iteritems(self.kube_config.kube_env_vars):
 
 Review comment:
   ```suggestion
           for env_var_name, env_var_val in self.kube_config.kube_env_vars.items():
   ```
   
   Airflow dropped Python 2 support, so no need to use the six library. Other than that, looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7663: [AIRFLOW-6997] Make sure worker pods initcontainers obtain env vars f…

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7663: [AIRFLOW-6997] Make sure worker pods initcontainers obtain env vars f…
URL: https://github.com/apache/airflow/pull/7663#issuecomment-596513356
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7663?src=pr&el=h1) Report
   > Merging [#7663](https://codecov.io/gh/apache/airflow/pull/7663?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/ad9d5f328650f6f74bf47672154d96858bdc66ea?src=pr&el=desc) will **decrease** coverage by `0.38%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7663/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7663?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff               @@
   ##           v1-10-test    #7663      +/-   ##
   ==============================================
   - Coverage       81.64%   81.26%   -0.39%     
   ==============================================
     Files             529      529              
     Lines           36448    36455       +7     
   ==============================================
   - Hits            29759    29624     -135     
   - Misses           6689     6831     +142
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7663?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/contrib/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvd29ya2VyX2NvbmZpZ3VyYXRpb24ucHk=) | `96.47% <100%> (+0.05%)` | :arrow_up: |
   | [airflow/contrib/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvdm9sdW1lX21vdW50LnB5) | `33.33% <0%> (-66.67%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvdm9sdW1lLnB5) | `50% <0%> (-50%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kX2xhdW5jaGVyLnB5) | `45.11% <0%> (-47.37%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kX2dlbmVyYXRvci5weQ==) | `42.5% <0%> (-45%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `56.84% <0%> (-40.01%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcmVmcmVzaF9jb25maWcucHk=) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/contrib/kubernetes/pod.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMvcG9kLnB5) | `95.83% <0%> (-4.17%)` | :arrow_down: |
   | [...etes\_request\_factory/kubernetes\_request\_factory.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2t1YmVybmV0ZXMva3ViZXJuZXRlc19yZXF1ZXN0X2ZhY3Rvcnkva3ViZXJuZXRlc19yZXF1ZXN0X2ZhY3RvcnkucHk=) | `99.13% <0%> (-0.87%)` | :arrow_down: |
   | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `93.01% <0%> (-0.48%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7663/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7663?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7663?src=pr&el=footer). Last update [ad9d5f3...6bc1e3c](https://codecov.io/gh/apache/airflow/pull/7663?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on issue #7663: [AIRFLOW-6997] Fix worker pods initcontainers

Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #7663: [AIRFLOW-6997] Fix worker pods initcontainers
URL: https://github.com/apache/airflow/pull/7663#issuecomment-599794746
 
 
   @Fokko lgtm!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] Fokko merged pull request #7663: [AIRFLOW-6997] Fix worker pods initcontainers

Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #7663: [AIRFLOW-6997] Fix worker pods initcontainers
URL: https://github.com/apache/airflow/pull/7663
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] Fokko commented on a change in pull request #7663: [AIRFLOW-6997] Fix worker pods initcontainers

Posted by GitBox <gi...@apache.org>.
Fokko commented on a change in pull request #7663: [AIRFLOW-6997] Fix worker pods initcontainers
URL: https://github.com/apache/airflow/pull/7663#discussion_r393265538
 
 

 ##########
 File path: airflow/contrib/kubernetes/worker_configuration.py
 ##########
 @@ -73,6 +73,13 @@ def _get_init_containers(self):
             'name': 'GIT_SYNC_REV',
             'value': self.kube_config.git_sync_rev
         }]
+
+        for env_var_name, env_var_val in six.iteritems(self.kube_config.kube_env_vars):
 
 Review comment:
   This is targeted for the v1-10 branch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] Fokko commented on issue #7663: [AIRFLOW-6997] Fix worker pods initcontainers

Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #7663: [AIRFLOW-6997] Fix worker pods initcontainers
URL: https://github.com/apache/airflow/pull/7663#issuecomment-600044893
 
 
   Thanks @krisgeus for the PR 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7663: [AIRFLOW-6997] Fix worker pods initcontainers

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7663: [AIRFLOW-6997] Fix worker pods initcontainers
URL: https://github.com/apache/airflow/pull/7663#issuecomment-600044541
 
 
   Awesome work, congrats on your first merged pull request!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services