You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "XiaokaiWang (Code Review)" <ge...@cloudera.org> on 2019/07/19 05:56:58 UTC
[kudu-CR] [docs]: Delete invalid link
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13881
Change subject: [docs]: Delete invalid link
......................................................................
[docs]: Delete invalid link
Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
---
M docs/design-docs/cfile.md
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/13881/1
--
To view, visit http://gerrit.cloudera.org:8080/13881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
Gerrit-Change-Number: 13881
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
[kudu-CR] [docs]: Delete invalid link
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.
Change subject: [docs]: Delete invalid link
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
Gerrit-Change-Number: 13881
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] [docs]: Delete invalid link
Posted by "XiaokaiWang (Code Review)" <ge...@cloudera.org>.
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13881 )
Change subject: [docs]: Delete invalid link
......................................................................
Patch Set 1:
> (1 comment)
Hmm, this will return back to 'Dictionary encoding' title, but actually that is where we are reading. Is this necessary?
--
To view, visit http://gerrit.cloudera.org:8080/13881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
Gerrit-Change-Number: 13881
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 07:20:45 +0000
Gerrit-HasComments: No
[kudu-CR] [docs]: Delete invalid link
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13881 )
Change subject: [docs]: Delete invalid link
......................................................................
Patch Set 1: Verified+1 Code-Review+2
> Hmm, this will return back to 'Dictionary encoding' title, but actually that is where we are reading. Is this necessary?
Agreed; a link referring back to the same section isn't useful.
Overriding Jenkins; the ASAN failure is unrelated to this patch.
--
To view, visit http://gerrit.cloudera.org:8080/13881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
Gerrit-Change-Number: 13881
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 03:24:50 +0000
Gerrit-HasComments: No
[kudu-CR] [docs]: Delete invalid link
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13881 )
Change subject: [docs]: Delete invalid link
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13881/1/docs/design-docs/cfile.md
File docs/design-docs/cfile.md:
http://gerrit.cloudera.org:8080/#/c/13881/1/docs/design-docs/cfile.md@155
PS1, Line 155: Dictionary encoding may be used for BINARY or STRING
Maybe like this: [Dictionary encoding](#dictionary-encoding)
--
To view, visit http://gerrit.cloudera.org:8080/13881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
Gerrit-Change-Number: 13881
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 07:11:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs]: Delete invalid link
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13881 )
Change subject: [docs]: Delete invalid link
......................................................................
[docs]: Delete invalid link
Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
Reviewed-on: http://gerrit.cloudera.org:8080/13881
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M docs/design-docs/cfile.md
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13881
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4
Gerrit-Change-Number: 13881
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>