You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/12/19 07:19:48 UTC
[GitHub] [hbase] saintstack opened a new pull request #952: HBASE-23596
HBCKServerCrashProcedure can double assign
saintstack opened a new pull request #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952
First attempt. Will be back after testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-570367692
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ branch-2.2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 34s | branch-2.2 passed |
| +1 :green_heart: | compile | 1m 22s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 2m 13s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 30s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 58s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 26s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 39s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 14s | the patch passed |
| +1 :green_heart: | compile | 1m 22s | the patch passed |
| +1 :green_heart: | javac | 1m 22s | the patch passed |
| -1 :x: | checkstyle | 1m 32s | hbase-server: The patch generated 1 new + 224 unchanged - 0 fixed = 225 total (was 224) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 24s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 37s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 58s | the patch passed |
| +1 :green_heart: | findbugs | 5m 1s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 3m 30s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 202m 8s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. |
| | | 270m 10s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/7/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/952 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e36c9b4c6e9d 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-952/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / 3887752b8e |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/7/artifact/out/diff-checkstyle-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/7/testReport/ |
| Max. process+thread count | 4813 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/7/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-568158247
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-2.2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 11s | branch-2.2 passed |
| +1 :green_heart: | compile | 0m 54s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 1m 19s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 7s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | branch-2.2 passed |
| +0 :ok: | spotbugs | 2m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 44s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 45s | the patch passed |
| +1 :green_heart: | compile | 0m 55s | the patch passed |
| +1 :green_heart: | javac | 0m 55s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 17s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 1s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 0s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +1 :green_heart: | findbugs | 3m 17s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 321m 29s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. |
| | | 374m 20s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.master.procedure.TestSCPWithReplicas |
| | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.replication.TestReplicationAdminWithClusters |
| | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
| | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
| | hadoop.hbase.replication.TestReplicationSmallTests |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/952 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 781247dcd53e 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-952/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / 0a989eae4e |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/6/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/6/testReport/ |
| Max. process+thread count | 5297 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/6/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #952:
HBASE-23596 HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#discussion_r362567378
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/HBCKServerCrashProcedure.java
##########
@@ -65,31 +75,91 @@ public HBCKServerCrashProcedure(final MasterProcedureEnv env, final ServerName s
public HBCKServerCrashProcedure() {}
/**
- * Adds Regions found by super method any found scanning hbase:meta.
+ * If no Regions found in Master context, then we will search hbase:meta for references
+ * to the passed server. Operator may have passed ServerName because they have found
+ * references to 'Unknown Servers'. They are using HBCKSCP to clear them out.
*/
@Override
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_NULL_ON_SOME_PATH_EXCEPTION",
justification="FindBugs seems confused on ps in below.")
List<RegionInfo> getRegionsOnCrashedServer(MasterProcedureEnv env) {
- // Super can return immutable emptyList.
+ // Super will return an immutable list (empty if nothing on this server).
List<RegionInfo> ris = super.getRegionsOnCrashedServer(env);
- List<Pair<RegionInfo, ServerName>> ps = null;
+ if (!ris.isEmpty()) {
+ return ris;
+ }
+ // Nothing in in-master context. Check for Unknown Server! in hbase:meta.
+ // If super list is empty, then allow that an operator scheduled an SCP because they are trying
+ // to purge 'Unknown Servers' -- servers that are neither online nor in dead servers
+ // list but that ARE in hbase:meta and so showing as unknown in places like 'HBCK Report'.
+ // This mis-accounting does not happen in normal circumstance but may arise in-extremis
+ // when cluster has been damaged in operation.
+ UnknownServerVisitor visitor =
+ new UnknownServerVisitor(env.getMasterServices().getConnection(), getServerName());
try {
- ps = MetaTableAccessor.getTableRegionsAndLocations(env.getMasterServices().getConnection(),
- null, false);
+ MetaTableAccessor.scanMetaForTableRegions(env.getMasterServices().getConnection(),
+ visitor, null);
} catch (IOException ioe) {
- LOG.warn("Failed get of all regions; continuing", ioe);
- }
- if (ps == null || ps.isEmpty()) {
- LOG.warn("No regions found in hbase:meta");
+ LOG.warn("Failed scan of hbase:meta for 'Unknown Servers'", ioe);
return ris;
}
- List<RegionInfo> aggregate = ris == null || ris.isEmpty()?
- new ArrayList<>(): new ArrayList<>(ris);
- int before = aggregate.size();
- ps.stream().filter(p -> p.getSecond() != null && p.getSecond().equals(getServerName())).
- forEach(p -> aggregate.add(p.getFirst()));
- LOG.info("Found {} mentions of {} in hbase:meta", aggregate.size() - before, getServerName());
- return aggregate;
+ LOG.info("Found {} mentions of {} in hbase:meta of OPEN/OPENING Regions: {}",
+ visitor.getReassigns().size(), getServerName(),
+ visitor.getReassigns().stream().map(RegionInfo::getEncodedName).
+ collect(Collectors.joining(",")));
+ return visitor.getReassigns();
+ }
+
+ /**
+ * Visitor for hbase:meta that 'fixes' Unknown Server issues. Collects
+ * a List of Regions to reassign as 'result'.
+ */
+ static class UnknownServerVisitor implements MetaTableAccessor.Visitor {
+ private final List<RegionInfo> reassigns = new ArrayList<>();
+ private final ServerName unknownServerName;
+ private final Connection connection;
+
+ UnknownServerVisitor(Connection connection, ServerName unknownServerName) {
+ this.connection = connection;
+ this.unknownServerName = unknownServerName;
+ }
+
+ @Override
+ public boolean visit(Result result) throws IOException {
+ RegionLocations rls = MetaTableAccessor.getRegionLocations(result);
Review comment:
rls would never be null in our case right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-570448079
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ branch-2.2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 5s | branch-2.2 passed |
| +1 :green_heart: | compile | 1m 20s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 2m 0s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 1s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 15s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 25s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 48s | the patch passed |
| +1 :green_heart: | compile | 1m 20s | the patch passed |
| +1 :green_heart: | javac | 1m 20s | the patch passed |
| -1 :x: | checkstyle | 1m 23s | hbase-server: The patch generated 2 new + 224 unchanged - 0 fixed = 226 total (was 224) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 7s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 10s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 1m 0s | the patch passed |
| +1 :green_heart: | findbugs | 4m 36s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 3m 43s | hbase-client in the patch passed. |
| -1 :x: | unit | 262m 23s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 1m 4s | The patch does not generate ASF License warnings. |
| | | 326m 24s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/8/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/952 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b9f36b1a6c37 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-952/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / 3887752b8e |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/8/artifact/out/diff-checkstyle-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/8/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/8/testReport/ |
| Max. process+thread count | 4437 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/8/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-570378132
I'd like to push this on branch-2.3 because what is there currently could cause damage.
Since this code only cuts in at an extreme when invoked by an operator via hbck2 and passed a server that has NO references in master memory context, and since I have two +1s for an earlier invocation that was more radical than this, I'm going to push.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-570319857
Thanks for review @virajjasani ... let me update to address your first comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #952:
HBASE-23596 HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#discussion_r362603116
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/HBCKServerCrashProcedure.java
##########
@@ -65,31 +75,91 @@ public HBCKServerCrashProcedure(final MasterProcedureEnv env, final ServerName s
public HBCKServerCrashProcedure() {}
/**
- * Adds Regions found by super method any found scanning hbase:meta.
+ * If no Regions found in Master context, then we will search hbase:meta for references
+ * to the passed server. Operator may have passed ServerName because they have found
+ * references to 'Unknown Servers'. They are using HBCKSCP to clear them out.
*/
@Override
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_NULL_ON_SOME_PATH_EXCEPTION",
justification="FindBugs seems confused on ps in below.")
List<RegionInfo> getRegionsOnCrashedServer(MasterProcedureEnv env) {
- // Super can return immutable emptyList.
+ // Super will return an immutable list (empty if nothing on this server).
List<RegionInfo> ris = super.getRegionsOnCrashedServer(env);
- List<Pair<RegionInfo, ServerName>> ps = null;
+ if (!ris.isEmpty()) {
+ return ris;
+ }
+ // Nothing in in-master context. Check for Unknown Server! in hbase:meta.
+ // If super list is empty, then allow that an operator scheduled an SCP because they are trying
+ // to purge 'Unknown Servers' -- servers that are neither online nor in dead servers
+ // list but that ARE in hbase:meta and so showing as unknown in places like 'HBCK Report'.
+ // This mis-accounting does not happen in normal circumstance but may arise in-extremis
+ // when cluster has been damaged in operation.
+ UnknownServerVisitor visitor =
+ new UnknownServerVisitor(env.getMasterServices().getConnection(), getServerName());
try {
- ps = MetaTableAccessor.getTableRegionsAndLocations(env.getMasterServices().getConnection(),
- null, false);
+ MetaTableAccessor.scanMetaForTableRegions(env.getMasterServices().getConnection(),
+ visitor, null);
} catch (IOException ioe) {
- LOG.warn("Failed get of all regions; continuing", ioe);
- }
- if (ps == null || ps.isEmpty()) {
- LOG.warn("No regions found in hbase:meta");
+ LOG.warn("Failed scan of hbase:meta for 'Unknown Servers'", ioe);
return ris;
}
- List<RegionInfo> aggregate = ris == null || ris.isEmpty()?
- new ArrayList<>(): new ArrayList<>(ris);
- int before = aggregate.size();
- ps.stream().filter(p -> p.getSecond() != null && p.getSecond().equals(getServerName())).
- forEach(p -> aggregate.add(p.getFirst()));
- LOG.info("Found {} mentions of {} in hbase:meta", aggregate.size() - before, getServerName());
- return aggregate;
+ LOG.info("Found {} mentions of {} in hbase:meta of OPEN/OPENING Regions: {}",
+ visitor.getReassigns().size(), getServerName(),
+ visitor.getReassigns().stream().map(RegionInfo::getEncodedName).
+ collect(Collectors.joining(",")));
+ return visitor.getReassigns();
+ }
+
+ /**
+ * Visitor for hbase:meta that 'fixes' Unknown Server issues. Collects
+ * a List of Regions to reassign as 'result'.
+ */
+ static class UnknownServerVisitor implements MetaTableAccessor.Visitor {
+ private final List<RegionInfo> reassigns = new ArrayList<>();
+ private final ServerName unknownServerName;
+ private final Connection connection;
+
+ UnknownServerVisitor(Connection connection, ServerName unknownServerName) {
+ this.connection = connection;
+ this.unknownServerName = unknownServerName;
+ }
+
+ @Override
+ public boolean visit(Result result) throws IOException {
+ RegionLocations rls = MetaTableAccessor.getRegionLocations(result);
Review comment:
Shouldn't be but let me handle it; when this code is running the hbase:meta could be messed up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-568187290
Something wonky here. This HBCKSCP is only called via hbck2 (or by its unit test) so no other tests should be failing (and they pass locally). I'm in no hurry to commit this. Still testing so will try figure what is up here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack closed pull request #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack closed pull request #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #952:
HBASE-23596 HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#discussion_r362568604
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/HBCKServerCrashProcedure.java
##########
@@ -65,31 +75,91 @@ public HBCKServerCrashProcedure(final MasterProcedureEnv env, final ServerName s
public HBCKServerCrashProcedure() {}
/**
- * Adds Regions found by super method any found scanning hbase:meta.
+ * If no Regions found in Master context, then we will search hbase:meta for references
+ * to the passed server. Operator may have passed ServerName because they have found
+ * references to 'Unknown Servers'. They are using HBCKSCP to clear them out.
*/
@Override
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_NULL_ON_SOME_PATH_EXCEPTION",
justification="FindBugs seems confused on ps in below.")
List<RegionInfo> getRegionsOnCrashedServer(MasterProcedureEnv env) {
- // Super can return immutable emptyList.
+ // Super will return an immutable list (empty if nothing on this server).
List<RegionInfo> ris = super.getRegionsOnCrashedServer(env);
- List<Pair<RegionInfo, ServerName>> ps = null;
+ if (!ris.isEmpty()) {
+ return ris;
+ }
+ // Nothing in in-master context. Check for Unknown Server! in hbase:meta.
+ // If super list is empty, then allow that an operator scheduled an SCP because they are trying
+ // to purge 'Unknown Servers' -- servers that are neither online nor in dead servers
+ // list but that ARE in hbase:meta and so showing as unknown in places like 'HBCK Report'.
+ // This mis-accounting does not happen in normal circumstance but may arise in-extremis
+ // when cluster has been damaged in operation.
+ UnknownServerVisitor visitor =
+ new UnknownServerVisitor(env.getMasterServices().getConnection(), getServerName());
try {
- ps = MetaTableAccessor.getTableRegionsAndLocations(env.getMasterServices().getConnection(),
- null, false);
+ MetaTableAccessor.scanMetaForTableRegions(env.getMasterServices().getConnection(),
+ visitor, null);
} catch (IOException ioe) {
- LOG.warn("Failed get of all regions; continuing", ioe);
- }
- if (ps == null || ps.isEmpty()) {
- LOG.warn("No regions found in hbase:meta");
+ LOG.warn("Failed scan of hbase:meta for 'Unknown Servers'", ioe);
return ris;
}
- List<RegionInfo> aggregate = ris == null || ris.isEmpty()?
- new ArrayList<>(): new ArrayList<>(ris);
- int before = aggregate.size();
- ps.stream().filter(p -> p.getSecond() != null && p.getSecond().equals(getServerName())).
- forEach(p -> aggregate.add(p.getFirst()));
- LOG.info("Found {} mentions of {} in hbase:meta", aggregate.size() - before, getServerName());
- return aggregate;
+ LOG.info("Found {} mentions of {} in hbase:meta of OPEN/OPENING Regions: {}",
+ visitor.getReassigns().size(), getServerName(),
+ visitor.getReassigns().stream().map(RegionInfo::getEncodedName).
+ collect(Collectors.joining(",")));
+ return visitor.getReassigns();
+ }
+
+ /**
+ * Visitor for hbase:meta that 'fixes' Unknown Server issues. Collects
+ * a List of Regions to reassign as 'result'.
+ */
+ static class UnknownServerVisitor implements MetaTableAccessor.Visitor {
+ private final List<RegionInfo> reassigns = new ArrayList<>();
+ private final ServerName unknownServerName;
+ private final Connection connection;
+
+ UnknownServerVisitor(Connection connection, ServerName unknownServerName) {
+ this.connection = connection;
+ this.unknownServerName = unknownServerName;
+ }
+
+ @Override
+ public boolean visit(Result result) throws IOException {
+ RegionLocations rls = MetaTableAccessor.getRegionLocations(result);
+ for (HRegionLocation hrl: rls.getRegionLocations()) {
+ if (hrl.getRegion() == null) {
+ continue;
+ }
+ if (hrl.getServerName() == null) {
+ continue;
+ }
+ if (!hrl.getServerName().equals(this.unknownServerName)) {
+ continue;
+ }
Review comment:
Above 3 conditions can be combined for `continue`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-570323623
Address @virajjasani review comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-568134778
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 18s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-2.2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 24s | branch-2.2 passed |
| +1 :green_heart: | compile | 1m 0s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 1m 24s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 13s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 32s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 30s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 8s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 22s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 21s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 40s | the patch passed |
| +1 :green_heart: | findbugs | 4m 3s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 353m 51s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. |
| | | 412m 13s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.master.procedure.TestSCPWithReplicas |
| | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.replication.TestReplicationAdminWithClusters |
| | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
| | hadoop.hbase.master.procedure.TestProcedurePriority |
| | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL |
| | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
| | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
| | hadoop.hbase.replication.TestReplicationSmallTests |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/952 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6bbed9cd8995 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-952/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / 5ec99b4f10 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/5/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/5/testReport/ |
| Max. process+thread count | 4880 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/5/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #952:
HBASE-23596 HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#discussion_r362602789
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/HBCKServerCrashProcedure.java
##########
@@ -65,31 +75,91 @@ public HBCKServerCrashProcedure(final MasterProcedureEnv env, final ServerName s
public HBCKServerCrashProcedure() {}
/**
- * Adds Regions found by super method any found scanning hbase:meta.
+ * If no Regions found in Master context, then we will search hbase:meta for references
+ * to the passed server. Operator may have passed ServerName because they have found
+ * references to 'Unknown Servers'. They are using HBCKSCP to clear them out.
*/
@Override
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_NULL_ON_SOME_PATH_EXCEPTION",
justification="FindBugs seems confused on ps in below.")
List<RegionInfo> getRegionsOnCrashedServer(MasterProcedureEnv env) {
- // Super can return immutable emptyList.
+ // Super will return an immutable list (empty if nothing on this server).
List<RegionInfo> ris = super.getRegionsOnCrashedServer(env);
- List<Pair<RegionInfo, ServerName>> ps = null;
+ if (!ris.isEmpty()) {
+ return ris;
+ }
+ // Nothing in in-master context. Check for Unknown Server! in hbase:meta.
+ // If super list is empty, then allow that an operator scheduled an SCP because they are trying
+ // to purge 'Unknown Servers' -- servers that are neither online nor in dead servers
+ // list but that ARE in hbase:meta and so showing as unknown in places like 'HBCK Report'.
+ // This mis-accounting does not happen in normal circumstance but may arise in-extremis
+ // when cluster has been damaged in operation.
+ UnknownServerVisitor visitor =
+ new UnknownServerVisitor(env.getMasterServices().getConnection(), getServerName());
try {
- ps = MetaTableAccessor.getTableRegionsAndLocations(env.getMasterServices().getConnection(),
- null, false);
+ MetaTableAccessor.scanMetaForTableRegions(env.getMasterServices().getConnection(),
+ visitor, null);
} catch (IOException ioe) {
- LOG.warn("Failed get of all regions; continuing", ioe);
- }
- if (ps == null || ps.isEmpty()) {
- LOG.warn("No regions found in hbase:meta");
+ LOG.warn("Failed scan of hbase:meta for 'Unknown Servers'", ioe);
return ris;
}
- List<RegionInfo> aggregate = ris == null || ris.isEmpty()?
- new ArrayList<>(): new ArrayList<>(ris);
- int before = aggregate.size();
- ps.stream().filter(p -> p.getSecond() != null && p.getSecond().equals(getServerName())).
- forEach(p -> aggregate.add(p.getFirst()));
- LOG.info("Found {} mentions of {} in hbase:meta", aggregate.size() - before, getServerName());
- return aggregate;
+ LOG.info("Found {} mentions of {} in hbase:meta of OPEN/OPENING Regions: {}",
+ visitor.getReassigns().size(), getServerName(),
+ visitor.getReassigns().stream().map(RegionInfo::getEncodedName).
+ collect(Collectors.joining(",")));
+ return visitor.getReassigns();
+ }
+
+ /**
+ * Visitor for hbase:meta that 'fixes' Unknown Server issues. Collects
+ * a List of Regions to reassign as 'result'.
+ */
+ static class UnknownServerVisitor implements MetaTableAccessor.Visitor {
+ private final List<RegionInfo> reassigns = new ArrayList<>();
+ private final ServerName unknownServerName;
+ private final Connection connection;
+
+ UnknownServerVisitor(Connection connection, ServerName unknownServerName) {
+ this.connection = connection;
+ this.unknownServerName = unknownServerName;
+ }
+
+ @Override
+ public boolean visit(Result result) throws IOException {
+ RegionLocations rls = MetaTableAccessor.getRegionLocations(result);
+ for (HRegionLocation hrl: rls.getRegionLocations()) {
+ if (hrl.getRegion() == null) {
+ continue;
+ }
+ if (hrl.getServerName() == null) {
+ continue;
+ }
+ if (!hrl.getServerName().equals(this.unknownServerName)) {
+ continue;
+ }
Review comment:
As is it is an easier read IMO!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-567896267
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-2.2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 14s | branch-2.2 passed |
| +1 :green_heart: | compile | 0m 55s | branch-2.2 passed |
| +1 :green_heart: | checkstyle | 1m 22s | branch-2.2 passed |
| +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | branch-2.2 passed |
| +0 :ok: | spotbugs | 3m 12s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 10s | branch-2.2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 45s | the patch passed |
| +1 :green_heart: | compile | 0m 54s | the patch passed |
| +1 :green_heart: | javac | 0m 54s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 18s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 6s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed |
| +1 :green_heart: | findbugs | 3m 17s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 329m 0s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
| | | 382m 30s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestFromClientSide3 |
| | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.replication.TestReplicationAdminWithClusters |
| | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
| | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
| | hadoop.hbase.client.TestAsyncTableAdminApi |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL |
| | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
| | hadoop.hbase.replication.TestReplicationSmallTests |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/952 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 565c7da534c3 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-952/out/precommit/personality/provided.sh |
| git revision | branch-2.2 / a841bf15b0 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/4/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/4/testReport/ |
| Max. process+thread count | 5226 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-952/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-570284702
Update is yet more conservative than previous only reassigning 'Unknown Servers' if shown as OPEN or OPENING in the hbase:meta table (previous we'd reassign any 'Unknown Server' referenced Region).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #952: HBASE-23596
HBCKServerCrashProcedure can double assign
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #952: HBASE-23596 HBCKServerCrashProcedure can double assign
URL: https://github.com/apache/hbase/pull/952#issuecomment-570381053
Merged by hand to branch-2.2+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services