You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "tuhaihe (via GitHub)" <gi...@apache.org> on 2026/09/03 08:39:29 UTC
[PR] Fix smgr_hook bypass in zeroextend and release [cloudberry]
tuhaihe opened a new pull request, #1953:
URL: https://github.com/apache/cloudberry/pull/1953
smgrrelease() and smgrzeroextend() dispatch through smgrsw[reln->smgr_which] instead of reln->smgr, so an f_smgr installed by smgr_hook is silently bypassed. Both arrived with the REL_16_9 merge in upstream form; every other entry point in smgr.c already goes through reln->smgr.
smgrrelease() is harmless for the in-tree managers. smgrzeroextend() is not: it is the bulk-extension path from ExtendBufferedRelShared(), and reaching mdzeroextend() unhooked makes register_dirty_segment() tag the checkpointer fsync request with the un-redirected path. That file never exists, so the next checkpoint PANICs with "could not fsync file ...: No such file or directory" and the segment enters a crash/restart loop.
Nothing changes when no hook is installed, since smgropen() sets reln->smgr to &smgrsw[reln->smgr_which].
Assisted-by: Claude Code
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix smgr_hook bypass in zeroextend and release [cloudberry]
Posted by "reshke (via GitHub)" <gi...@apache.org>.
reshke commented on code in PR #1953:
URL: https://github.com/apache/cloudberry/pull/1953#discussion_r4028146567
##########
src/backend/storage/smgr/smgr.c:
##########
@@ -696,8 +696,8 @@ void
smgrzeroextend(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
int nblocks, bool skipFsync)
{
- smgrsw[reln->smgr_which].smgr_zeroextend(reln, forknum, blocknum,
- nblocks, skipFsync);
+ (*reln->smgr).smgr_zeroextend(reln, forknum, blocknum,
Review Comment:
Normally it shouldn't, but lets add a check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix smgr_hook bypass in zeroextend and release [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #1953:
URL: https://github.com/apache/cloudberry/pull/1953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix smgr_hook bypass in zeroextend and release [cloudberry]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #1953:
URL: https://github.com/apache/cloudberry/pull/1953#discussion_r4120200057
##########
src/backend/storage/smgr/smgr.c:
##########
@@ -696,8 +696,8 @@ void
smgrzeroextend(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
int nblocks, bool skipFsync)
{
- smgrsw[reln->smgr_which].smgr_zeroextend(reln, forknum, blocknum,
- nblocks, skipFsync);
+ (*reln->smgr).smgr_zeroextend(reln, forknum, blocknum,
Review Comment:
Updated in 7ebf778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix smgr_hook bypass in zeroextend and release [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1953:
URL: https://github.com/apache/cloudberry/pull/1953#discussion_r3952039314
##########
src/backend/storage/smgr/smgr.c:
##########
@@ -696,8 +696,8 @@ void
smgrzeroextend(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
int nblocks, bool skipFsync)
{
- smgrsw[reln->smgr_which].smgr_zeroextend(reln, forknum, blocknum,
- nblocks, skipFsync);
+ (*reln->smgr).smgr_zeroextend(reln, forknum, blocknum,
Review Comment:
reln->smgr.smgr_zeroextend maybe NULL ? @reshke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix smgr_hook bypass in zeroextend and release [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1953:
URL: https://github.com/apache/cloudberry/pull/1953#discussion_r3952039314
##########
src/backend/storage/smgr/smgr.c:
##########
@@ -696,8 +696,8 @@ void
smgrzeroextend(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
int nblocks, bool skipFsync)
{
- smgrsw[reln->smgr_which].smgr_zeroextend(reln, forknum, blocknum,
- nblocks, skipFsync);
+ (*reln->smgr).smgr_zeroextend(reln, forknum, blocknum,
Review Comment:
reln->smgr maybe NULL ? @reshke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org