You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2023/08/29 22:28:44 UTC

[GitHub] [airflow] o-nikolas commented on a diff in pull request #33881: Remove tasks annotation in `AppflowHook`

o-nikolas commented on code in PR #33881:
URL: https://github.com/apache/airflow/pull/33881#discussion_r1309412539


##########
airflow/providers/amazon/aws/hooks/appflow.py:
##########
@@ -24,7 +24,6 @@
 
 if TYPE_CHECKING:
     from mypy_boto3_appflow.client import AppflowClient
-    from mypy_boto3_appflow.type_defs import TaskOutputTypeDef, TaskTypeDef
 

Review Comment:
   > @o-nikolas Do you think is it even possible to implements https://github.com/apache/airflow/issues/11297 or maybe we should decide that in won't fixed
   
   So far I've seen mostly grief working with these types packages, there was some breakage a week or so back as well. I'd agree with resolving as wont fix, for now, we can always re-open later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org