You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "agrueneberg (via GitHub)" <gi...@apache.org> on 2023/12/08 23:00:00 UTC

[PR] [MINOR][DOCS] Note that hudi.metadata-enabled in Trino is defunct [hudi]

agrueneberg opened a new pull request, #10289:
URL: https://github.com/apache/hudi/pull/10289

   `hudi.metadata-enabled` has been removed in Trino 426 (https://github.com/trinodb/trino/pull/18840) because it has been unused since Trino 419 (https://github.com/trinodb/trino/pull/17392). There is currently no support for reading from metadata tables in Trino.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR][DOCS] Note that hudi.metadata-enabled in Trino is defunct [hudi]

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #10289:
URL: https://github.com/apache/hudi/pull/10289


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR][DOCS] Note that hudi.metadata-enabled in Trino is defunct [hudi]

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #10289:
URL: https://github.com/apache/hudi/pull/10289#discussion_r1422294711


##########
website/docs/metadata.md:
##########
@@ -134,7 +134,7 @@ from different engines as shown below:
 |----------------------------------------------------------------------------------|------------------------|-------------------------------------------------------------------------------------------------------------------------------|
 | <ul><li>Spark DataSource</li><li>Spark SQL</li><li>Strucured Streaming</li></ul> | hoodie.metadata.enable | When set to `true` enables use of the spark file index implementation for Hudi, that speeds up listing of large tables.<br /> |
 |Presto| [hudi.metadata-table-enabled](https://prestodb.io/docs/current/connector/hudi.html)             | When set to `true` fetches the list of file names and sizes from Hudi’s metadata table rather than storage.                   |
-|Trino| [hudi.metadata-enabled](https://trino.io/docs/current/connector/hudi.html#general-configuration) | When set to `true` fetches the list of file names and sizes from metadata rather than storage.                                |
+|Trino| N/A | Support for reading from the metadata table [has been dropped in Trino 419](https://github.com/trinodb/trino/pull/17392). |

Review Comment:
   Can you please link the JIRA ticket where we are working on the fix - https://issues.apache.org/jira/browse/HUDI-7020



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR][DOCS] Note that hudi.metadata-enabled in Trino is defunct [hudi]

Posted by "agrueneberg (via GitHub)" <gi...@apache.org>.
agrueneberg commented on code in PR #10289:
URL: https://github.com/apache/hudi/pull/10289#discussion_r1422504644


##########
website/docs/metadata.md:
##########
@@ -134,7 +134,7 @@ from different engines as shown below:
 |----------------------------------------------------------------------------------|------------------------|-------------------------------------------------------------------------------------------------------------------------------|
 | <ul><li>Spark DataSource</li><li>Spark SQL</li><li>Strucured Streaming</li></ul> | hoodie.metadata.enable | When set to `true` enables use of the spark file index implementation for Hudi, that speeds up listing of large tables.<br /> |
 |Presto| [hudi.metadata-table-enabled](https://prestodb.io/docs/current/connector/hudi.html)             | When set to `true` fetches the list of file names and sizes from Hudi’s metadata table rather than storage.                   |
-|Trino| [hudi.metadata-enabled](https://trino.io/docs/current/connector/hudi.html#general-configuration) | When set to `true` fetches the list of file names and sizes from metadata rather than storage.                                |
+|Trino| N/A | Support for reading from the metadata table [has been dropped in Trino 419](https://github.com/trinodb/trino/pull/17392). |

Review Comment:
   Thanks @codope, I wasn't aware of that ticket. Linked to it instead and pushed again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR][DOCS] Note that hudi.metadata-enabled in Trino is defunct [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10289:
URL: https://github.com/apache/hudi/pull/10289#issuecomment-1848205635

   cc @codope for the reviewing ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org