[Bug 61337] Downgrade AssertionError to RuntimeException or something better

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61337

Tim Allison <ta...@mitre.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Tim Allison <ta...@mitre.org> ---
I see 73 instances of "assert(", and, yes, several of these are my fault.

In most cases, I'd think we could convert these to a RecordFormatException.  If
there were a use case for turning assertions off and hoping for the best, I'd
want to leave the asserts in.  However, it looks (on quick review) like turning
the assertions off will yield corrupt objects/data.  So, I don't see a use case
for assert instead of a RecordFormatException.

I'm happy to make the changes, but given that this will be not a small patch,
I'd like to get feedback before I fix this globally.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org