You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/20 13:10:45 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #36927: [SPARK-39534][PS] Series.argmax only needs single pass
zhengruifeng opened a new pull request, #36927:
URL: https://github.com/apache/spark/pull/36927
### What changes were proposed in this pull request?
compute `Series.argmax ` with one pass
### Why are the changes needed?
existing implemation of `Series.argmax` needs two pass on the dataset, the first one is to compute the maximum value, and the second one is to get the index.
However, they can be computed on one pass.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #36927: [SPARK-39534][PS] Series.argmax only needs single pass
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36927: [SPARK-39534][PS] Series.argmax only needs single pass
URL: https://github.com/apache/spark/pull/36927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #36927: [SPARK-39534][PS] Series.argmax only needs single pass
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #36927:
URL: https://github.com/apache/spark/pull/36927#issuecomment-1161195094
thanks @HyukjinKwon for reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36927: [SPARK-39534][PS] Series.argmax only needs single pass
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36927:
URL: https://github.com/apache/spark/pull/36927#issuecomment-1160966557
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org