You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/06 04:15:30 UTC
Re: Review Request 65062: Cleaned up endpoint directories after RP
config agent API tests.
> On Jan. 25, 2018, 9:29 p.m., Greg Mann wrote:
> > src/tests/agent_resource_provider_config_api_tests.cpp
> > Lines 202 (patched)
> > <https://reviews.apache.org/r/65062/diff/1/?file=1938031#file1938031line202>
> >
> > Are you certain this is necessary? Can we rely on the cleanup provided by `Environment`?
Dropping this as the cleanup is already done in `cluster.cpp`. See https://reviews.apache.org/r/65060.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65062/#review196287
-----------------------------------------------------------
On Jan. 10, 2018, 3:05 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65062/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 3:05 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Bugs: MESOS-8427
> https://issues.apache.org/jira/browse/MESOS-8427
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up endpoint directories after RP config agent API tests.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 7cbee5cceef2963b736f3e6ce3f52fcf0b3c029c
>
>
> Diff: https://reviews.apache.org/r/65062/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>