You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "315157973 (via GitHub)" <gi...@apache.org> on 2024/02/04 01:47:05 UTC
[PR] [fix] [test] fix flaky test testPerTopicExpiredStat [pulsar]
315157973 opened a new pull request, #22018:
URL: https://github.com/apache/pulsar/pull/22018
### Motivation
Large floats may fail to convert because of commas in the string
<img width="1016" alt="image" src="https://github.com/apache/pulsar/assets/9758905/bf43083b-5a2a-42a7-966b-a38da4465b0e">
### Modifications
Change to BigDecimal
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [test] Fix flaky test testPerTopicExpiredStat [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #22018:
URL: https://github.com/apache/pulsar/pull/22018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix] [test] Fix flaky test testPerTopicExpiredStat [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22018:
URL: https://github.com/apache/pulsar/pull/22018#issuecomment-1925596812
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22018?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`e7c2a75`)](https://app.codecov.io/gh/apache/pulsar/commit/e7c2a75473b545134a3b292ae0e87a79d65cb756?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 73.64% compared to head [(`5706f86`)](https://app.codecov.io/gh/apache/pulsar/pull/22018?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 73.64%.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/22018?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #22018 +/- ##
=========================================
Coverage 73.64% 73.64%
- Complexity 32476 32497 +21
=========================================
Files 1863 1863
Lines 138816 138816
Branches 15217 15217
=========================================
+ Hits 102229 102233 +4
- Misses 28688 28696 +8
+ Partials 7899 7887 -12
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22018/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.09% <ø> (-0.09%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/22018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.91% <ø> (-0.07%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22018/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.91% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 51 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22018/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org