[GitHub] [metamodel] arjansh edited a comment on issue #229: Upgrade to Elasticsearch 7.3.1

[GitBox <gi...@apache.org>]

arjansh edited a comment on issue #229: Upgrade to Elasticsearch 7.3.1
URL: https://github.com/apache/metamodel/pull/229#issuecomment-543538321
 
 
   That's a thought that I was having too, but I also have to fix a little bug in the AbstractElasticSearchDataSet#close() method, which is also involved, because the logic which detects if it should actually close the DataSet isn't implemented in the right manner (so right now it doesn't actually close it when the close method is invoked). And I want to add a few tests to demonstrate the issue.
   
   But you maybe right and it maybe better to do that in a separate PR, but then this one preferably should be merged first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services