You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2016/01/04 21:57:49 UTC
[GitHub] incubator-twill pull request: (TWILL-160) Don’t create parent di...
GitHub user chtyim opened a pull request:
https://github.com/apache/incubator-twill/pull/75
(TWILL-160) Don’t create parent directory when getting InputStream from a LocalLocation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/incubator-twill feature/TWILL-160
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 7b1a9c48fb3f203209b0106ca113ab22641733dc
Author: Terence Yim <ch...@apache.org>
Date: 2016-01-04T20:57:18Z
(TWILL-160) Don’t create parent directory when getting InputStream from a LocalLocation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-160) Don’t create parent di...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-twill/pull/75#issuecomment-168810148
Hi Terence,
Do you know why parent directory was created before? The JIRA did not have information about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-160) Don’t create parent di...
Posted by chtyim <gi...@git.apache.org>.
Github user chtyim commented on the pull request:
https://github.com/apache/incubator-twill/pull/75#issuecomment-168841867
@hsaputra I believe it just a bug. The usual convention of creating InputStream from file shouldn't create anything in the FS if the file doesn't exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-160) Don’t create parent di...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-twill/pull/75#issuecomment-168868065
:+1:
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-160) Don’t create parent di...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on the pull request:
https://github.com/apache/incubator-twill/pull/75#issuecomment-168808509
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-160) Don’t create parent di...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-twill/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---